Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1695233002: wasm - replace the WLL section with support to skip all unknown sections. (Closed)

Created:
4 years, 10 months ago by dougc
Modified:
4 years, 9 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

wasm - replace the WLL section with support to skip all unknown sections. A section dedicated to WLL seems to be blocking consensus, so this patch offers to remove it and replace it with support to skip all unknown sections. The WLL section is relegated to an acknowledgment in a table with just the section number and a link. The numbers are expected to be replaced by strings in future and the namespace table might be managed by some community group in future. This patch also moves to using a fixed width encoding for the size of these sections as there has been some interest in back patching such sizes. BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M src/wasm/module-decoder.cc View 1 1 chunk +5 lines, -12 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 4 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
dougc
4 years, 10 months ago (2016-02-15 10:55:17 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698