Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: sdk/lib/io/http_parser.dart

Issue 16952005: dart:io | Rename optional carryOverData argument to SecureSocket.secureServer to bufferedData. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/secure_socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_parser.dart
diff --git a/sdk/lib/io/http_parser.dart b/sdk/lib/io/http_parser.dart
index bcd27e018c89ddda1ee0c65ae0be63a93b28838e..f863e4fcf9e70c42054ab822911c79641e6c5c38 100644
--- a/sdk/lib/io/http_parser.dart
+++ b/sdk/lib/io/http_parser.dart
@@ -99,13 +99,13 @@ class _HttpDetachedIncoming extends Stream<List<int>> {
StreamController<List<int>> controller;
final StreamSubscription subscription;
- List<int> carryOverData;
+ List<int> bufferedData;
bool paused;
Completer resumeCompleter;
_HttpDetachedIncoming(StreamSubscription this.subscription,
- List<int> this.carryOverData) {
+ List<int> this.bufferedData) {
controller = new StreamController<List<int>>(
sync: true,
onListen: resume,
@@ -114,7 +114,7 @@ class _HttpDetachedIncoming extends Stream<List<int>> {
onCancel: () => subscription.cancel());
if (subscription == null) {
// Socket was already closed.
- if (carryOverData != null) controller.add(carryOverData);
+ if (bufferedData != null) controller.add(bufferedData);
controller.close();
} else {
pause();
@@ -138,9 +138,9 @@ class _HttpDetachedIncoming extends Stream<List<int>> {
void resume() {
paused = false;
- if (carryOverData != null) {
- var data = carryOverData;
- carryOverData = null;
+ if (bufferedData != null) {
+ var data = bufferedData;
+ bufferedData = null;
controller.add(data);
// If the consumer pauses again after the carry-over data, we'll not
// continue our subscriber until the next resume.
« no previous file with comments | « no previous file | sdk/lib/io/secure_socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698