Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1695193003: [crankshaft] Remove the global arguments object from the HGraph. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove the global arguments object from the HGraph. This was actually only necessary for dealing with %_Arguments and %_ArgumentsLength in Crankshaft, which have been removed recently, so there's no need to keep this piece of awesomeness around any longer. R=jarin@chromium.org Committed: https://crrev.com/242404923dfe801ea00dbe5e9f9485b33ad217ee Cr-Commit-Position: refs/heads/master@{#34015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M src/crankshaft/hydrogen.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-16 06:54:48 UTC) #1
Benedikt Meurer
Hey Jaro, Simple cleanup after %_Arguments removal. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-16 06:55:22 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-16 06:56:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695193003/1
4 years, 10 months ago (2016-02-16 06:57:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 07:30:10 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 07:30:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/242404923dfe801ea00dbe5e9f9485b33ad217ee
Cr-Commit-Position: refs/heads/master@{#34015}

Powered by Google App Engine
This is Rietveld 408576698