Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1695133002: Update lzma_sdk binaries to x64 builds of 15.14. (Closed)

Created:
4 years, 10 months ago by grt (UTC plus 2)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, Sorin Jianu
Base URL:
https://chromium.googlesource.com/chromium/src.git@586201
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M third_party/lzma_sdk/7zr.exe View Binary file 0 comments Download
M third_party/lzma_sdk/Executable/7za.exe View Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
grt (UTC plus 2)
Here are the binaries (from 7-zip.org) that accompany the source change in https://codereview.chromium.org/1700453002/. I will ...
4 years, 10 months ago (2016-02-15 02:04:19 UTC) #4
waffles
lgtm, but IIUC, these are built by 7-zip.org, not by us from the source, correct? ...
4 years, 10 months ago (2016-02-16 18:56:04 UTC) #5
grt (UTC plus 2)
On 2016/02/16 18:56:04, waffles wrote: > lgtm, but IIUC, these are built by http://7-zip.org, not ...
4 years, 10 months ago (2016-02-16 21:53:54 UTC) #6
waffles
On 2016/02/16 21:53:54, grt wrote: > On 2016/02/16 18:56:04, waffles wrote: > > lgtm, but ...
4 years, 10 months ago (2016-02-16 22:00:16 UTC) #7
grt (UTC plus 2)
Okay, thanks. I'll land this (TBR jochen, who approved the source changes) once the dry ...
4 years, 10 months ago (2016-02-17 14:34:42 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695133002/20001
4 years, 10 months ago (2016-02-17 14:34:51 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 15:44:07 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e1369f53f8941203d13301b5667f77cd2d2a307 Cr-Commit-Position: refs/heads/master@{#375893}
4 years, 10 months ago (2016-02-17 15:56:26 UTC) #16
grt (UTC plus 2)
4 years, 10 months ago (2016-02-17 15:57:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
4e1369f53f8941203d13301b5667f77cd2d2a307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698