Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 169513003: Write telemetry-specific network interface file. (Closed)

Created:
6 years, 10 months ago by slamm
Modified:
6 years, 10 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Write telemetry-specific network interface file. Avoid sudo for stopping network-manager if already stopped. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251965

Patch Set 1 #

Total comments: 1

Patch Set 2 : Support hosts that do not use /etc/network/interfaces.d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 1 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
slamm
6 years, 10 months ago (2014-02-18 22:23:12 UTC) #1
tonyg
everything else lg. Thanks for doing this :) https://codereview.chromium.org/169513003/diff/1/tools/telemetry/telemetry/core/forwarders/android_forwarder.py File tools/telemetry/telemetry/core/forwarders/android_forwarder.py (right): https://codereview.chromium.org/169513003/diff/1/tools/telemetry/telemetry/core/forwarders/android_forwarder.py#newcode155 tools/telemetry/telemetry/core/forwarders/android_forwarder.py:155: _INTERFACES_FILE_TEMPLATE ...
6 years, 10 months ago (2014-02-18 22:36:56 UTC) #2
slamm
PTAL Good point about hosts without Google-specific setup. This version creates /etc/network/interfaces.d and sources the ...
6 years, 10 months ago (2014-02-19 00:24:36 UTC) #3
tonyg
lgtm
6 years, 10 months ago (2014-02-19 00:28:40 UTC) #4
slamm
The CQ bit was checked by slamm@chromium.org
6 years, 10 months ago (2014-02-19 00:31:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@chromium.org/169513003/100001
6 years, 10 months ago (2014-02-19 00:34:19 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:20:12 UTC) #7
Message was sent while issue was closed.
Change committed as 251965

Powered by Google App Engine
This is Rietveld 408576698