Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 16951017: convert pathops to use SkSTArray where possible. (Closed)

Created:
7 years, 6 months ago by caryclark
Modified:
7 years, 6 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

convert pathops to use SkSTArray where possible. Replace SkTDArray with SkTArray and use SkSTArray when the probable array size is known. In a couple of places (spans, chases) the arrays are constructed using insert() so SkTArrays can't be used for now. Also, add an optimization to cubic subdivide if either end is zero or one. BUG= Committed: https://code.google.com/p/skia/source/detail?r=9635

Patch Set 1 #

Patch Set 2 : fix for mac #

Patch Set 3 : pathops use SkTArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -162 lines) Patch
M src/pathops/SkAddIntersections.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pathops/SkAddIntersections.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkDCubicIntersection.cpp View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
M src/pathops/SkDCubicToQuads.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/pathops/SkDQuadIntersection.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkOpAngle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pathops/SkOpContour.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkOpContour.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M src/pathops/SkOpSegment.h View 7 chunks +18 lines, -15 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 24 chunks +44 lines, -39 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 chunk +8 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 16 chunks +22 lines, -22 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkReduceOrder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkReduceOrder.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsCubicToQuadsTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/PathOpsTestCommon.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsTestCommon.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caryclark
7 years, 6 months ago (2013-06-17 14:11:16 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r9635 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698