Remove TextDatabase from the history service.

chrome/browser/history/visit_database.cc

Index: chrome/browser/history/visit_database.cc
diff --git a/chrome/browser/history/visit_database.cc b/chrome/browser/history/visit_database.cc
index 883fe6f4e18569974336b58b8519816c8f18fcdd..e8e88056ad72b5ce6efdbc01d8e9b23ff5c97a67 100644
--- a/chrome/browser/history/visit_database.cc
+++ b/chrome/browser/history/visit_database.cc
@@ -34,8 +34,7 @@ bool VisitDatabase::InitVisitTable() {
         "from_visit INTEGER,"
         "transition INTEGER DEFAULT 0 NOT NULL,"
         "segment_id INTEGER,"
-        // True when we have indexed data for this visit.
-        "is_indexed BOOLEAN,"
+        "is_indexed BOOLEAN,"  // unused field - kept to avoid recreating DB.

[brettw, 2013/07/17 17:39:56]

We should be able to remove this line and tolerate some older DBs that have it
and new ones that don't (we should probably write a comment here explaining how
some DB's will have this column and why). As long as we never read or write to
it, everything will be fine.

[rmcilroy, 2013/07/18 11:42:52]

Done.

         "visit_duration INTEGER DEFAULT 0 NOT NULL)"))
       return false;
   } else if (!GetDB().DoesColumnExist("visits", "is_indexed")) {

[brettw, 2013/07/17 17:39:56]

They we can also remove this block.

[rmcilroy, 2013/07/18 11:42:52]

Done.

@@ -98,7 +97,6 @@ void VisitDatabase::FillVisitRow(sql::Statement& statement, VisitRow* visit) {
   visit->referring_visit = statement.ColumnInt64(3);
   visit->transition = content::PageTransitionFromInt(statement.ColumnInt(4));
   visit->segment_id = statement.ColumnInt64(5);
-  visit->is_indexed = !!statement.ColumnInt(6);
   visit->visit_duration =
       base::TimeDelta::FromInternalValue(statement.ColumnInt64(7));
 }
@@ -154,15 +152,14 @@ bool VisitDatabase::FillVisitVectorWithOptions(sql::Statement& statement,
 VisitID VisitDatabase::AddVisit(VisitRow* visit, VisitSource source) {
   sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
       "INSERT INTO visits "
-      "(url, visit_time, from_visit, transition, segment_id, is_indexed, "
-      "visit_duration) VALUES (?,?,?,?,?,?,?)"));
+      "(url, visit_time, from_visit, transition, segment_id, "
+      "visit_duration) VALUES (?,?,?,?,?,?)"));
   statement.BindInt64(0, visit->url_id);
   statement.BindInt64(1, visit->visit_time.ToInternalValue());
   statement.BindInt64(2, visit->referring_visit);
   statement.BindInt64(3, visit->transition);
   statement.BindInt64(4, visit->segment_id);
-  statement.BindInt64(5, visit->is_indexed);
-  statement.BindInt64(6, visit->visit_duration.ToInternalValue());
+  statement.BindInt64(5, visit->visit_duration.ToInternalValue());
 
   if (!statement.Run()) {
     VLOG(0) << "Failed to execute visit insert statement:  "
@@ -241,16 +238,15 @@ bool VisitDatabase::UpdateVisitRow(const VisitRow& visit) {
 
   sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
       "UPDATE visits SET "
-      "url=?,visit_time=?,from_visit=?,transition=?,segment_id=?,is_indexed=?,"
+      "url=?,visit_time=?,from_visit=?,transition=?,segment_id=?,"
       "visit_duration=? WHERE id=?"));
   statement.BindInt64(0, visit.url_id);
   statement.BindInt64(1, visit.visit_time.ToInternalValue());
   statement.BindInt64(2, visit.referring_visit);
   statement.BindInt64(3, visit.transition);
   statement.BindInt64(4, visit.segment_id);
-  statement.BindInt64(5, visit.is_indexed);
-  statement.BindInt64(6, visit.visit_duration.ToInternalValue());
-  statement.BindInt64(7, visit.visit_id);
+  statement.BindInt64(5, visit.visit_duration.ToInternalValue());
+  statement.BindInt64(6, visit.visit_id);
 
   return statement.Run();
 }
@@ -267,17 +263,6 @@ bool VisitDatabase::GetVisitsForURL(URLID url_id, VisitVector* visits) {
   return FillVisitVector(statement, visits);
 }
 
-bool VisitDatabase::GetIndexedVisitsForURL(URLID url_id, VisitVector* visits) {
-  visits->clear();
-
-  sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
-      "SELECT" HISTORY_VISIT_ROW_FIELDS
-      "FROM visits "
-      "WHERE url=? AND is_indexed=1"));
-  statement.BindInt64(0, url_id);
-  return FillVisitVector(statement, visits);
-}
-
 bool VisitDatabase::GetVisitsForURLWithOptions(URLID url_id,
                                                const QueryOptions& options,
                                                VisitVector* visits) {