Issue 16951012: Add the missing commas before MEMORY_TOOL_REPLACES_ALLOCATOR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16951012: Add the missing commas before MEMORY_TOOL_REPLACES_ALLOCATOR. (Closed)

Created:
7 years, 6 months ago by Alexander Potapenko

Modified:
7 years, 6 months ago

Reviewers:
Nico, (unused - use chromium), Chris Evans

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Add the missing commas before MEMORY_TOOL_REPLACES_ALLOCATOR. This should fix the current failures on the heapcheck bots. BUG=246860 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206399

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/common.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Alexander Potapenko

Committed patchset #2 manually as r206399 (presubmit successful).

7 years, 6 months ago (2013-06-14 12:29:38 UTC) #1

Chris Evans

7 years, 6 months ago (2013-06-14 18:49:38 UTC) #4

Message was sent while issue was closed.

On 2013/06/14 17:32:06, Nico wrote:
> lgtm
> 
> Sorry for missing this :-(

Whoa, I suck... sorry for coding it. LGTM etc.