Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: Source/core/html/canvas/DataView.idl

Issue 16951005: Add support for byte and octet Web IDL types to the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take Joshua's feedback into consideration Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8DataViewCustom.cpp ('k') | Source/core/testing/TypeConversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/canvas/DataView.idl
diff --git a/Source/core/html/canvas/DataView.idl b/Source/core/html/canvas/DataView.idl
index c814a6b756b02b8031e4e53f52c339017e633333..5ff575df00b71832de3c1833d4b9bc36cd7dd3c7 100644
--- a/Source/core/html/canvas/DataView.idl
+++ b/Source/core/html/canvas/DataView.idl
@@ -30,11 +30,8 @@
] interface DataView : ArrayBufferView {
// All these methods raise an exception if they would read or write beyond the end of the view.
- // We have to use custom code because our code generator does not support int8_t type.
- // int8_t getInt8(unsigned long byteOffset);
- // uint8_t getUint8(unsigned long byteOffset);
- [Custom, RaisesException] any getInt8();
- [Custom, RaisesException] any getUint8();
+ [RaisesException] byte getInt8(unsigned long byteOffset);
+ [RaisesException] octet getUint8(unsigned long byteOffset);
[StrictTypeChecking, RaisesException] short getInt16(unsigned long byteOffset, optional boolean littleEndian);
[StrictTypeChecking, RaisesException] unsigned short getUint16(unsigned long byteOffset, optional boolean littleEndian);
@@ -45,11 +42,8 @@
[StrictTypeChecking, RaisesException] float getFloat32(unsigned long byteOffset, optional boolean littleEndian);
[StrictTypeChecking, RaisesException] double getFloat64(unsigned long byteOffset, optional boolean littleEndian);
- // We have to use custom code because our code generator does not support uint8_t type.
- // void setInt8(unsigned long byteOffset, int8_t value);
- // void setUint8(unsigned long byteOffset, uint8_t value);
- [Custom, RaisesException] void setInt8();
- [Custom, RaisesException] void setUint8();
+ [RaisesException] void setInt8(unsigned long byteOffset, byte value);
+ [RaisesException] void setUint8(unsigned long byteOffset, octet value);
[StrictTypeChecking, RaisesException] void setInt16(unsigned long byteOffset, short value, optional boolean littleEndian);
[StrictTypeChecking, RaisesException] void setUint16(unsigned long byteOffset, unsigned short value, optional boolean littleEndian);
« no previous file with comments | « Source/bindings/v8/custom/V8DataViewCustom.cpp ('k') | Source/core/testing/TypeConversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698