Handle alternate types in HandleMouseEvent.

ui/views/widget/native_widget_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_win.h"
 
 #include <dwmapi.h>
 #include <shellapi.h>
 
 #include <algorithm>
@@ skipping 725 matching lines @@
 }
 
 void NativeWidgetWin::HandleNativeBlur(HWND focused_window) {
   delegate_->OnNativeBlur(focused_window);
   InputMethod* input_method = GetInputMethod();
   if (input_method)
     input_method->OnBlur();
 }
 
 bool NativeWidgetWin::HandleMouseEvent(const ui::MouseEvent& event) {
-  ui::MouseEvent dpi_event(event);
-  dpi_event.set_location(ui::win::ScreenToDIPPoint(event.location()));
-  dpi_event.set_root_location(ui::win::ScreenToDIPPoint(event.location()));
-  delegate_->OnMouseEvent(&dpi_event);
-  return dpi_event.handled();
+  if (event.IsMouseWheelEvent()) {
+    ui::MouseWheelEvent dpi_event(event,
+      static_cast<const ui::MouseWheelEvent&>(event).x_offset() /
+      ui::win::GetDeviceScaleFactor(),
+      static_cast<const ui::MouseWheelEvent&>(event).y_offset() /
+      ui::win::GetDeviceScaleFactor());

[sadrul, 2013/06/24 02:09:35]

Most of the ui::Events are copyable. Looks like MouseWheelEvents aren't. It
probably makes more sense to just allow copying a MouseWheelEvent, so you can
just do:
  ui::MouseWheelEvent dpi_event(event);
(like for the MouseEvent case below)

[girard, 2013/06/24 20:37:07]

If we do this, we'd still need the static_cast in the call to the c'tor. (No big
deal). We would also need to expose a set_x_offset()/set_y_offset().

I think a cleaner approach would be to switch to a call to
UpdateForRootTransform() after constructing either event, and implement
MouseWheelEvent::UpdateForRootTransform.

+    dpi_event.set_location(ui::win::ScreenToDIPPoint(event.location()));
+    dpi_event.set_root_location(ui::win::ScreenToDIPPoint(event.location()));
+    delegate_->OnMouseEvent(&dpi_event);
+    return dpi_event.handled();
+  } else if (event.IsScrollEvent()) {

[sadrul, 2013/06/24 02:09:35]

scroll events (i.e. ET_SCROLL*) are never generated on windows. So you can
simplify this:
  if (event.type() == ui::ET_MOUSEWHEEL) {
    ...
  } else {
    CHECK(!event.IsScrollEvent());  <-- not really necessary
    ...
  }

[girard, 2013/06/24 20:37:07]

Thanks - cleaned this up. (I was trying to be more conservative/paranoid on the
types supported.)

+    ui::ScrollEvent dpi_event(static_cast<const ui::ScrollEvent&>(event));
+    dpi_event.Scale(1/ui::win::GetDeviceScaleFactor());
+    dpi_event.set_location(ui::win::ScreenToDIPPoint(event.location()));
+    dpi_event.set_root_location(ui::win::ScreenToDIPPoint(event.location()));
+    delegate_->OnMouseEvent(&dpi_event);
+    return dpi_event.handled();
+  } else if (event.IsMouseEvent()) {
+    ui::MouseEvent dpi_event(event);
+    dpi_event.set_location(ui::win::ScreenToDIPPoint(event.location()));
+    dpi_event.set_root_location(ui::win::ScreenToDIPPoint(event.location()));
+    delegate_->OnMouseEvent(&dpi_event);
+    return dpi_event.handled();
+  }
+  NOTREACHED();
+  return false;
 }
 
 bool NativeWidgetWin::HandleKeyEvent(const ui::KeyEvent& event) {
   delegate_->OnKeyEvent(const_cast<ui::KeyEvent*>(&event));
   return event.handled();
 }
 
 bool NativeWidgetWin::HandleUntranslatedKeyEvent(const ui::KeyEvent& event) {
   InputMethod* input_method = GetInputMethod();
   if (input_method)
@@ skipping 252 matching lines @@
 // static
 bool NativeWidgetPrivate::IsTouchDown() {
   // This currently isn't necessary because we're not generating touch events on
   // windows.  When we do, this will need to be updated.
   return false;
 }
 
 }  // namespace internal
 
 }  // namespace views