Issue 16950023: aura: Use the WindowSlider for gesture-nav while the page is reloading.

Issue 16950023: aura: Use the WindowSlider for gesture-nav while the page is reloading. (Closed)

Created:
7 years, 6 months ago by sadrul

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Use the WindowSlider for gesture-nav while the page is reloading. Allow navigating through history at the end of a gesture-nav, while the page is still reloading from the previous gesture nav. BUG=196607 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207959

Patch Set 1 #

Patch Set 2 : test-self-review #

Total comments: 2

Patch Set 3 : more-test #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+356 lines, -24 lines)			Patch
M	content/browser/web_contents/aura/window_slider.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/aura/window_slider.cc	View	1 2	8 chunks	+28 lines, -10 lines	0 comments	Download
M	content/browser/web_contents/aura/window_slider_unittest.cc	View	1 2	7 chunks	+142 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View	1 2	10 chunks	+184 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/16950023/diff/6001/content/browser/web_contents/aura/window_slider.h File content/browser/web_contents/aura/window_slider.h (right): https://codereview.chromium.org/16950023/diff/6001/content/browser/web_contents/aura/window_slider.h#newcode68 content/browser/web_contents/aura/window_slider.h:68: bool SlideIsInProgress() const; IsSlideInProgress?

7 years, 6 months ago (2013-06-21 21:16:54 UTC) #2

sadrul

https://codereview.chromium.org/16950023/diff/6001/content/browser/web_contents/aura/window_slider.h File content/browser/web_contents/aura/window_slider.h (right): https://codereview.chromium.org/16950023/diff/6001/content/browser/web_contents/aura/window_slider.h#newcode68 content/browser/web_contents/aura/window_slider.h:68: bool SlideIsInProgress() const; On 2013/06/21 21:16:54, sky wrote: > ...

7 years, 6 months ago (2013-06-21 23:48:53 UTC) #3

sadrul

7 years, 6 months ago (2013-06-21 23:49:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r207959 (presubmit successful).

Expand Messages | Collapse Messages