Issue 16950022: Skip syncing V8_bleeding_edge unless bisecting V8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16950022: Skip syncing V8_bleeding_edge unless bisecting V8. (Closed)

Created:
7 years, 6 months ago by shatch

Modified:
7 years, 6 months ago

Reviewers:
tonyg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Skip syncing V8_bleeding_edge unless bisecting V8. BUG=249038 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207873

Patch Set 2 : Changes from review. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -27 lines)			Patch
	M	tools/bisect-perf-regression.py	View	1	8 chunks	+27 lines, -7 lines	0 comments	Download
	M	tools/bisect_utils.py	View		6 chunks	+30 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/16950022/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/16950022/diff/1/tools/bisect-perf-regression.py#newcode1355 tools/bisect-perf-regression.py:1355: if DEPOT_DEPS_NAME[current_depot].has_key('custom_deps') and\ Nit: Please use parens instead ...

7 years, 6 months ago (2013-06-21 16:38:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/16950022/5001

7 years, 6 months ago (2013-06-21 17:36:59 UTC) #3

Message was sent while issue was closed.

Change committed as 207873

Expand Messages | Collapse Messages

Issue 16950022: Skip syncing V8_bleeding_edge unless bisecting V8. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Changes from review. #

Messages