add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular …

add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo

 https://code.google.com/p/chromium/issues/detail?id=247770

R=caryclark@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9724

[Stephen Chennney, 2013-06-21 17:19:05]

I'm fine with it - just one comment which is not blocking.

I'll defer to someone on the Skia team for a definitive OK.

https://codereview.chromium.org/16950021/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/16950021/diff/1/include/core/SkPath.h#newcode272
include/core/SkPath.h:272: bool isRect(SkRect* rect, bool* isClosed, Direction*
direction) const;
Is isClosed implied by a true return value? On other words, can something not
closed be a rect?

[reed1, 2013-06-21 17:24:03]

https://codereview.chromium.org/16950021/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/16950021/diff/1/include/core/SkPath.h#newcode272
include/core/SkPath.h:272: bool isRect(SkRect* rect, bool* isClosed, Direction*
direction) const;
On 2013/06/21 17:19:05, Stephen Chenney wrote:
> Is isClosed implied by a true return value? On other words, can something not
> closed be a rect?

move line line line line

that path is not closed, even if the move and final line specify the same
coordinate. isClosed has meaning when we stroke things: do I add two 'caps' or
one 'join' for that 4th corner. Thus we can return true and isClosed can be
either value.

For clients that intend to "fill" the path, they can ignore the isClosed value,
since it will fill the same way w/ or w/o a 'close' verb.

[caryclark, 2013-06-21 17:29:13]

lgtm

[reed1, 2013-06-21 17:32:37]

Committed patchset #1 manually as r9724 (presubmit successful).

[robertphillips, 2013-06-24 17:47:52]

This CL is causing the following assertion to fire on the Chrome trybots:

crash log for renderer (pid 26149):
STDOUT: <empty>
STDERR: [6:6:0624/134711:20976367823:INFO:SkGpuDevice.cpp(421)]
../../third_party/skia/src/gpu/SkGpuDevice.cpp(421) : 
devBound.contains(clipRegion.getBounds()) failed
STDERR: 
STDERR: #EOF

[robertphillips, 2013-06-25 15:40:18]

reverted in 9750