chrome/browser/notifications/desktop_notification_profile_util.h - Issue 1694923004: Use GURLs instead of patterns in SetContentSetting in notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_profile_util.h

Issue 1694923004: Use GURLs instead of patterns in SetContentSetting in notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: recover ClearSetting() for user input patterns to use SetContentSetting() directly Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/website_preference_bridge.cc ('k') | chrome/browser/notifications/desktop_notification_profile_util.cc » ('j') | chrome/browser/notifications/message_center_settings_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_profile_util.h

diff --git a/chrome/browser/notifications/desktop_notification_profile_util.h b/chrome/browser/notifications/desktop_notification_profile_util.h

index b36bbc46035676033686c0ea4b8c0c361ceaddb6..d477e6986d51ad635c5e2dfb1e00b8edb31dae7f 100644

--- a/chrome/browser/notifications/desktop_notification_profile_util.h

+++ b/chrome/browser/notifications/desktop_notification_profile_util.h

@@ -17,9 +17,8 @@ class DesktopNotificationProfileUtil {

// NOTE: This should only be called on the UI thread.

static void ResetToDefaultContentSetting(Profile* profile);

- // Clears the notifications setting for the given pattern.

- static void ClearSetting(

- Profile* profile, const ContentSettingsPattern& pattern);

+ // Clears the notifications setting for the given url.

+ static void ClearSetting(Profile* profile, const GURL& origin);

// Methods to setup and modify permission preferences.

static void GrantPermission(Profile* profile, const GURL& origin);