Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 1694893002: Avoid data race on Database::m_opened. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
michaeln, tkent
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid data race on Database::m_opened. Upon closing, the database thread will transition m_opened to |false|. Do that atomically so as to avoid a race when other threads check opened() status. R=michaeln BUG=580994 Committed: https://crrev.com/f935fbb21ab195c371509616e2c350c8790a128d Cr-Commit-Position: refs/heads/master@{#375353}

Patch Set 1 #

Patch Set 2 : iwyu #

Patch Set 3 : avoid casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/Database.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 2 5 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-12 21:59:08 UTC) #3
michaeln
lgtm
4 years, 10 months ago (2016-02-13 02:14:27 UTC) #4
michaeln
and thank you!
4 years, 10 months ago (2016-02-13 02:15:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694893002/40001
4 years, 10 months ago (2016-02-13 06:09:06 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-13 07:13:00 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:47:36 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f935fbb21ab195c371509616e2c350c8790a128d
Cr-Commit-Position: refs/heads/master@{#375353}

Powered by Google App Engine
This is Rietveld 408576698