components/offline_pages/offline_page_metadata_store_impl.h - Issue 1694863003: Refactor the offline page storage to include client namespace and id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_metadata_store_impl.h

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/offline_page_item.h ('K') | « components/offline_pages/offline_page_metadata_store.h ('k') | components/offline_pages/offline_page_metadata_store_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_metadata_store_impl.h

diff --git a/components/offline_pages/offline_page_metadata_store_impl.h b/components/offline_pages/offline_page_metadata_store_impl.h

index f5476f793aad5b5520284cabdd3a761a69233d7b..e3507ecb119dd6c62c43d6c83849959f330055ec 100644

--- a/components/offline_pages/offline_page_metadata_store_impl.h

+++ b/components/offline_pages/offline_page_metadata_store_impl.h

@@ -41,7 +41,7 @@ class OfflinePageMetadataStoreImpl : public OfflinePageMetadataStore {

void Load(const LoadCallback& callback) override;

void AddOrUpdateOfflinePage(const OfflinePageItem& offline_page_record,

const UpdateCallback& callback) override;

- void RemoveOfflinePages(const std::vector<int64_t>& bookmark_ids,

+ void RemoveOfflinePages(const std::vector<int64_t>& offline_ids,

const UpdateCallback& callback) override;

void Reset(const ResetCallback& callback) override;