chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java - Issue 1694863003: Refactor the offline page storage to include client namespace and id.

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address changes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java » ('j') | components/offline_pages/offline_page_metadata_store_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

index 46a3b945889c8ff662fd3b44dbab24a43914e6ea..06185e00b14a5a0bfb8624520d27297ea671a820 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

@@ -108,8 +108,6 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi

OfflinePageItem offlinePage = allPages.get(0);

assertEquals("Offline pages count incorrect.", 1, allPages.size());

assertEquals("Offline page item url incorrect.", mTestPage, offlinePage.getUrl());

- assertEquals("Offline page item bookmark ID incorrect.", BOOKMARK_ID,

- offlinePage.getBookmarkId());

assertTrue("Offline page item offline file url doesn't start properly.",

offlinePage.getOfflineUrl().startsWith("file:///"));

assertTrue("Offline page item offline file doesn't have the right name.",

@@ -227,8 +225,6 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi

savePage(SavePageResult.SUCCESS, mTestPage);

OfflinePageItem offlinePage = mOfflinePageBridge.getPageByBookmarkId(BOOKMARK_ID);

assertEquals("Offline page item url incorrect.", mTestPage, offlinePage.getUrl());

- assertEquals("Offline page item bookmark ID incorrect.", BOOKMARK_ID,

- offlinePage.getBookmarkId());

assertTrue("Offline page item offline file url doesn't start properly.",

offlinePage.getOfflineUrl().startsWith("file:///"));

assertTrue("Offline page item offline file doesn't have the right name.",

@@ -277,7 +273,8 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi

mOfflinePageBridge.savePage(getActivity().getActivityTab().getWebContents(),

BOOKMARK_ID, new SavePageCallback() {

@Override

- public void onSavePageDone(int savePageResult, String url) {

+ public void onSavePageDone(

+ int savePageResult, String url, long offlineId) {

assertEquals(

"Requested and returned URLs differ.", expectedUrl, url);

assertEquals(