Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: components/offline_pages/offline_page_metadata_store_impl_unittest.cc

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move id generation to C++, add DB migration Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_metadata_store_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
index 412ae2a85df09ead999cee536c315f56ad710f5a..40d7ce9cc0ec9e7e80905434f1afe1c507cbe852 100644
--- a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
+++ b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
@@ -145,13 +145,16 @@ TEST_F(OfflinePageMetadataStoreImplTest, AddOfflinePage) {
EXPECT_EQ(STATUS_TRUE, last_status_);
EXPECT_EQ(1U, offline_pages_.size());
EXPECT_EQ(offline_page.url, offline_pages_[0].url);
- EXPECT_EQ(offline_page.bookmark_id, offline_pages_[0].bookmark_id);
+ EXPECT_EQ(offline_page.offline_id, offline_pages_[0].offline_id);
EXPECT_EQ(offline_page.version, offline_pages_[0].version);
EXPECT_EQ(offline_page.file_path, offline_pages_[0].file_path);
EXPECT_EQ(offline_page.file_size, offline_pages_[0].file_size);
EXPECT_EQ(offline_page.creation_time, offline_pages_[0].creation_time);
EXPECT_EQ(offline_page.last_access_time, offline_pages_[0].last_access_time);
EXPECT_EQ(offline_page.access_count, offline_pages_[0].access_count);
+ EXPECT_EQ(offline_page.client_id, offline_pages_[0].client_id);
+ EXPECT_EQ(offline_page.client_id_name_space,
+ offline_pages_[0].client_id_name_space);
}
// Tests removing offline page metadata from the store, for which it first adds
@@ -181,7 +184,7 @@ TEST_F(OfflinePageMetadataStoreImplTest, RemoveOfflinePage) {
// Remove the offline page.
std::vector<int64_t> ids_to_remove;
- ids_to_remove.push_back(offline_page.bookmark_id);
+ ids_to_remove.push_back(offline_page.offline_id);
store->RemoveOfflinePages(
ids_to_remove,
base::Bind(&OfflinePageMetadataStoreImplTest::UpdateCallback,
@@ -252,7 +255,7 @@ TEST_F(OfflinePageMetadataStoreImplTest, AddRemoveMultipleOfflinePages) {
// Remove the offline page.
std::vector<int64_t> ids_to_remove;
- ids_to_remove.push_back(offline_page_1.bookmark_id);
+ ids_to_remove.push_back(offline_page_1.offline_id);
store->RemoveOfflinePages(
ids_to_remove,
base::Bind(&OfflinePageMetadataStoreImplTest::UpdateCallback,
@@ -274,7 +277,7 @@ TEST_F(OfflinePageMetadataStoreImplTest, AddRemoveMultipleOfflinePages) {
EXPECT_EQ(STATUS_TRUE, last_status_);
EXPECT_EQ(1U, offline_pages_.size());
EXPECT_EQ(offline_page_2.url, offline_pages_[0].url);
- EXPECT_EQ(offline_page_2.bookmark_id, offline_pages_[0].bookmark_id);
+ EXPECT_EQ(offline_page_2.offline_id, offline_pages_[0].offline_id);
EXPECT_EQ(offline_page_2.version, offline_pages_[0].version);
EXPECT_EQ(offline_page_2.file_path, offline_pages_[0].file_path);
EXPECT_EQ(offline_page_2.file_size, offline_pages_[0].file_size);
@@ -282,6 +285,9 @@ TEST_F(OfflinePageMetadataStoreImplTest, AddRemoveMultipleOfflinePages) {
EXPECT_EQ(offline_page_2.last_access_time,
offline_pages_[0].last_access_time);
EXPECT_EQ(offline_page_2.access_count, offline_pages_[0].access_count);
+ EXPECT_EQ(offline_page_2.client_id, offline_pages_[0].client_id);
+ EXPECT_EQ(offline_page_2.client_id_name_space,
+ offline_pages_[0].client_id_name_space);
}
// Tests updating offline page metadata from the store.
@@ -308,13 +314,16 @@ TEST_F(OfflinePageMetadataStoreImplTest, UpdateOfflinePage) {
EXPECT_EQ(STATUS_TRUE, last_status_);
EXPECT_EQ(1U, offline_pages_.size());
EXPECT_EQ(offline_page.url, offline_pages_[0].url);
- EXPECT_EQ(offline_page.bookmark_id, offline_pages_[0].bookmark_id);
+ EXPECT_EQ(offline_page.offline_id, offline_pages_[0].offline_id);
EXPECT_EQ(offline_page.version, offline_pages_[0].version);
EXPECT_EQ(offline_page.file_path, offline_pages_[0].file_path);
EXPECT_EQ(offline_page.file_size, offline_pages_[0].file_size);
EXPECT_EQ(offline_page.creation_time, offline_pages_[0].creation_time);
EXPECT_EQ(offline_page.last_access_time, offline_pages_[0].last_access_time);
EXPECT_EQ(offline_page.access_count, offline_pages_[0].access_count);
+ EXPECT_EQ(offline_page.client_id, offline_pages_[0].client_id);
+ EXPECT_EQ(offline_page.client_id_name_space,
+ offline_pages_[0].client_id_name_space);
// Then updates some data.
offline_page.file_size = kFileSize + 1;
@@ -336,13 +345,16 @@ TEST_F(OfflinePageMetadataStoreImplTest, UpdateOfflinePage) {
EXPECT_EQ(STATUS_TRUE, last_status_);
EXPECT_EQ(1U, offline_pages_.size());
EXPECT_EQ(offline_page.url, offline_pages_[0].url);
- EXPECT_EQ(offline_page.bookmark_id, offline_pages_[0].bookmark_id);
+ EXPECT_EQ(offline_page.offline_id, offline_pages_[0].offline_id);
EXPECT_EQ(offline_page.version, offline_pages_[0].version);
EXPECT_EQ(offline_page.file_path, offline_pages_[0].file_path);
EXPECT_EQ(offline_page.file_size, offline_pages_[0].file_size);
EXPECT_EQ(offline_page.creation_time, offline_pages_[0].creation_time);
EXPECT_EQ(offline_page.last_access_time, offline_pages_[0].last_access_time);
EXPECT_EQ(offline_page.access_count, offline_pages_[0].access_count);
+ EXPECT_EQ(offline_page.client_id, offline_pages_[0].client_id);
+ EXPECT_EQ(offline_page.client_id_name_space,
+ offline_pages_[0].client_id_name_space);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698