Refactor the offline page storage to include client namespace and id.

components/offline_pages/offline_page_metadata_store_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_metadata_store_impl.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 23 matching lines @@
 const char kDatabaseUMAClientName[] = "OfflinePageMetadataStore";
 }
 
 namespace offline_pages {
 namespace {
 
 void OfflinePageItemToEntry(const OfflinePageItem& item,
                             offline_pages::OfflinePageEntry* item_proto) {
   DCHECK(item_proto);
   item_proto->set_url(item.url.spec());
-  item_proto->set_bookmark_id(item.bookmark_id);
+  // TODO(bburns): switch this to offline id when we stop passing bookmark
+  //  id down.
+  item_proto->set_deprecated_bookmark_id(item.offline_id);
   item_proto->set_version(item.version);
   std::string path_string;
 #if defined(OS_POSIX)
   path_string = item.file_path.value();
 #elif defined(OS_WIN)
   path_string = base::WideToUTF8(item.file_path.value());
 #endif
   item_proto->set_file_path(path_string);
   item_proto->set_file_size(item.file_size);
   item_proto->set_creation_time(item.creation_time.ToInternalValue());
   item_proto->set_last_access_time(item.last_access_time.ToInternalValue());
   item_proto->set_access_count(item.access_count);
   item_proto->set_flags(
       static_cast<::offline_pages::OfflinePageEntry_Flags>(item.flags));
+  item_proto->set_client_id_name_space(item.client_id_name_space);
+  item_proto->set_client_id(item.client_id);
 }
 
 bool OfflinePageItemFromEntry(const offline_pages::OfflinePageEntry& item_proto,
                               OfflinePageItem* item) {
   DCHECK(item);
-  if (!item_proto.has_url() || !item_proto.has_bookmark_id() ||
+  if (!item_proto.has_url() || !item_proto.has_offline_id() ||
       !item_proto.has_version() || !item_proto.has_file_path()) {
     return false;
   }
   item->url = GURL(item_proto.url());
-  item->bookmark_id = item_proto.bookmark_id();
+  item->offline_id = item_proto.offline_id();
   item->version = item_proto.version();
 #if defined(OS_POSIX)
   item->file_path = base::FilePath(item_proto.file_path());
 #elif defined(OS_WIN)
   item->file_path = base::FilePath(base::UTF8ToWide(item_proto.file_path()));
 #endif
   if (item_proto.has_file_size()) {
     item->file_size = item_proto.file_size();
   }
   if (item_proto.has_creation_time()) {
     item->creation_time =
         base::Time::FromInternalValue(item_proto.creation_time());
   }
   if (item_proto.has_last_access_time()) {
     item->last_access_time =
         base::Time::FromInternalValue(item_proto.last_access_time());
   }
   if (item_proto.has_access_count()) {
     item->access_count = item_proto.access_count();
   }
   if (item_proto.has_flags()) {
     item->flags = static_cast<OfflinePageItem::Flags>(item_proto.flags());
   }
+  item->client_id_name_space = item_proto.client_id_name_space();
+  item->client_id = item_proto.client_id();
+
+  // Legacy storage.
+  if (item->client_id_name_space == ""
+      && item_proto.deprecated_bookmark_id() != 0) {

[fgorski, 2016/02/23 17:15:30]

we need to check for has_deprecated_bookmark_id, as 0 is a valid id.
-1 is the invalid one in case of bookmarks.

[bburns, 2016/02/23 19:25:38]

Done.

+    item->client_id_name_space = "bookmark";

[fgorski, 2016/02/23 17:15:30]

refer to const for bookmarks namespace

[bburns, 2016/02/23 19:25:38]

Done.

+    item->client_id = base::Int64ToString(item_proto.deprecated_bookmark_id());
+    if (item->offline_id == 0) {
+      item->offline_id = item_proto.deprecated_bookmark_id();
+    }
+  }
   return true;
 }
 
 }  // namespace
 
 OfflinePageMetadataStoreImpl::OfflinePageMetadataStoreImpl(
     scoped_refptr<base::SequencedTaskRunner> background_task_runner,
     const base::FilePath& database_dir)
     : background_task_runner_(background_task_runner),
       database_dir_(database_dir),
@@ skipping 77 matching lines @@
     const OfflinePageItem& offline_page_item,
     const UpdateCallback& callback) {
   scoped_ptr<ProtoDatabase<OfflinePageEntry>::KeyEntryVector> entries_to_save(
       new ProtoDatabase<OfflinePageEntry>::KeyEntryVector());
   scoped_ptr<std::vector<std::string>> keys_to_remove(
       new std::vector<std::string>());
 
   OfflinePageEntry offline_page_proto;
   OfflinePageItemToEntry(offline_page_item, &offline_page_proto);
   entries_to_save->push_back(
-      std::make_pair(base::Int64ToString(offline_page_item.bookmark_id),
+      std::make_pair(base::Int64ToString(offline_page_item.offline_id),
                      offline_page_proto));
 
   UpdateEntries(std::move(entries_to_save), std::move(keys_to_remove),
                 callback);
 }
 
 void OfflinePageMetadataStoreImpl::RemoveOfflinePages(
-    const std::vector<int64_t>& bookmark_ids,
+    const std::vector<int64_t>& offline_ids,
     const UpdateCallback& callback) {
   scoped_ptr<ProtoDatabase<OfflinePageEntry>::KeyEntryVector> entries_to_save(
       new ProtoDatabase<OfflinePageEntry>::KeyEntryVector());
   scoped_ptr<std::vector<std::string>> keys_to_remove(
       new std::vector<std::string>());
 
-  for (int64_t id : bookmark_ids)
+  for (int64_t id : offline_ids)
     keys_to_remove->push_back(base::Int64ToString(id));
 
   UpdateEntries(std::move(entries_to_save), std::move(keys_to_remove),
                 callback);
 }
 
 void OfflinePageMetadataStoreImpl::UpdateEntries(
     scoped_ptr<ProtoDatabase<OfflinePageEntry>::KeyEntryVector> entries_to_save,
     scoped_ptr<std::vector<std::string>> keys_to_remove,
     const UpdateCallback& callback) {
@@ skipping 34 matching lines @@
 
 void OfflinePageMetadataStoreImpl::ResetDone(
     const ResetCallback& callback,
     bool success) {
   database_.reset();
   weak_ptr_factory_.InvalidateWeakPtrs();
   callback.Run(success);
 }
 
 }  // namespace offline_pages