Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_bridge.h

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 15 matching lines...) Expand all
26 class OfflinePageBridge : public OfflinePageModel::Observer { 26 class OfflinePageBridge : public OfflinePageModel::Observer {
27 public: 27 public:
28 OfflinePageBridge(JNIEnv* env, 28 OfflinePageBridge(JNIEnv* env,
29 jobject obj, 29 jobject obj,
30 content::BrowserContext* browser_context); 30 content::BrowserContext* browser_context);
31 void Destroy(JNIEnv*, const base::android::JavaParamRef<jobject>&); 31 void Destroy(JNIEnv*, const base::android::JavaParamRef<jobject>&);
32 32
33 // OfflinePageModel::Observer implementation. 33 // OfflinePageModel::Observer implementation.
34 void OfflinePageModelLoaded(OfflinePageModel* model) override; 34 void OfflinePageModelLoaded(OfflinePageModel* model) override;
35 void OfflinePageModelChanged(OfflinePageModel* model) override; 35 void OfflinePageModelChanged(OfflinePageModel* model) override;
36 void OfflinePageDeleted(int64_t bookmark_id) override; 36 void OfflinePageDeleted(int64_t offline_id) override;
37 37
38 void GetAllPages(JNIEnv* env, 38 void GetAllPages(JNIEnv* env,
39 const base::android::JavaParamRef<jobject>& obj, 39 const base::android::JavaParamRef<jobject>& obj,
40 const base::android::JavaParamRef<jobject>& j_result_obj); 40 const base::android::JavaParamRef<jobject>& j_result_obj);
41 void GetPagesToCleanUp( 41 void GetPagesToCleanUp(
42 JNIEnv* env, 42 JNIEnv* env,
43 const base::android::JavaParamRef<jobject>& obj, 43 const base::android::JavaParamRef<jobject>& obj,
44 const base::android::JavaParamRef<jobject>& j_result_obj); 44 const base::android::JavaParamRef<jobject>& j_result_obj);
45 45
46 base::android::ScopedJavaLocalRef<jobject> GetPageByBookmarkId( 46 base::android::ScopedJavaLocalRef<jlongArray> GetOfflineIdsForClientId(
47 JNIEnv* env, 47 JNIEnv* env,
48 const base::android::JavaParamRef<jobject>& obj, 48 const base::android::JavaParamRef<jobject>& obj,
49 jlong bookmark_id); 49 const base::android::JavaParamRef<jstring>& client_id_namespace,
50 const base::android::JavaParamRef<jstring>& client_id);
51
52 base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId(
53 JNIEnv* env,
54 const base::android::JavaParamRef<jobject>& obj,
55 jlong offline_id);
50 56
51 base::android::ScopedJavaLocalRef<jobject> GetPageByOnlineURL( 57 base::android::ScopedJavaLocalRef<jobject> GetPageByOnlineURL(
52 JNIEnv* env, 58 JNIEnv* env,
53 const base::android::JavaParamRef<jobject>& obj, 59 const base::android::JavaParamRef<jobject>& obj,
54 const base::android::JavaParamRef<jstring>& online_url); 60 const base::android::JavaParamRef<jstring>& online_url);
55 61
56 void SavePage(JNIEnv* env, 62 void SavePage(JNIEnv* env,
57 const base::android::JavaParamRef<jobject>& obj, 63 const base::android::JavaParamRef<jobject>& obj,
58 const base::android::JavaParamRef<jobject>& j_callback_obj, 64 const base::android::JavaParamRef<jobject>& j_callback_obj,
59 const base::android::JavaParamRef<jobject>& j_web_contents, 65 const base::android::JavaParamRef<jobject>& j_web_contents,
60 jlong bookmark_id); 66 jlong offline_id,
67 const base::android::JavaParamRef<jstring>& client_id_namespace,
68 const base::android::JavaParamRef<jstring>& client_id);
61 69
62 void MarkPageAccessed(JNIEnv* env, 70 void MarkPageAccessed(JNIEnv* env,
63 const base::android::JavaParamRef<jobject>& obj, 71 const base::android::JavaParamRef<jobject>& obj,
64 jlong bookmark_id); 72 jlong offline_id);
65 73
66 void DeletePage(JNIEnv* env, 74 void DeletePage(JNIEnv* env,
67 const base::android::JavaParamRef<jobject>& obj, 75 const base::android::JavaParamRef<jobject>& obj,
68 const base::android::JavaParamRef<jobject>& j_callback_obj, 76 const base::android::JavaParamRef<jobject>& j_callback_obj,
69 jlong bookmark_id); 77 jlong offline_id);
70 78
71 void DeletePages( 79 void DeletePages(
72 JNIEnv* env, 80 JNIEnv* env,
73 const base::android::JavaParamRef<jobject>& obj, 81 const base::android::JavaParamRef<jobject>& obj,
74 const base::android::JavaParamRef<jobject>& j_callback_obj, 82 const base::android::JavaParamRef<jobject>& j_callback_obj,
75 const base::android::JavaParamRef<jlongArray>& bookmark_ids_array); 83 const base::android::JavaParamRef<jlongArray>& offline_ids_array);
76 84
77 void CheckMetadataConsistency( 85 void CheckMetadataConsistency(
78 JNIEnv* env, 86 JNIEnv* env,
79 const base::android::JavaParamRef<jobject>& obj); 87 const base::android::JavaParamRef<jobject>& obj);
80 88
81 base::android::ScopedJavaLocalRef<jstring> GetOfflineUrlForOnlineUrl( 89 base::android::ScopedJavaLocalRef<jstring> GetOfflineUrlForOnlineUrl(
82 JNIEnv* env, 90 JNIEnv* env,
83 const base::android::JavaParamRef<jobject>& obj, 91 const base::android::JavaParamRef<jobject>& obj,
84 const base::android::JavaParamRef<jstring>& j_online_url); 92 const base::android::JavaParamRef<jstring>& j_online_url);
85 93
(...skipping 18 matching lines...) Expand all
104 DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge); 112 DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge);
105 }; 113 };
106 114
107 bool RegisterOfflinePageBridge(JNIEnv* env); 115 bool RegisterOfflinePageBridge(JNIEnv* env);
108 116
109 } // namespace android 117 } // namespace android
110 } // namespace offline_pages 118 } // namespace offline_pages
111 119
112 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_ 120 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
113 121
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698