Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: components/offline_pages/proto/offline_pages.proto

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Offline page item protocol for storage and exchanging of offline page 5 // Offline page item protocol for storage and exchanging of offline page
6 // metadata. 6 // metadata.
7 7
8 syntax = "proto2"; 8 syntax = "proto2";
9 9
10 option optimize_for = LITE_RUNTIME; 10 option optimize_for = LITE_RUNTIME;
11 option retain_unknown_fields = true; 11 option retain_unknown_fields = true;
12 12
13 package offline_pages; 13 package offline_pages;
14 14
15 message OfflinePageEntry { 15 message OfflinePageEntry {
16 // URL of the offline page. 16 // URL of the offline page.
17 optional string url = 1; 17 optional string url = 1;
18 18
19 // Bookmark ID of the offline page. 19 // Bookmark ID of the offline page, this is deprecated in favor of the
20 optional int64 bookmark_id = 2; 20 // more generic ClientID below. No new pages should have this field.
21 optional int64 deprecated_bookmark_id = 2 [default = -1];
22
23 // Offline ID of the page. Every page entry has a unique offline_id.
24 optional int64 offline_id = 10;
21 25
22 // Version of the offline page metadata. 26 // Version of the offline page metadata.
23 optional int32 version = 3; 27 optional int32 version = 3;
24 28
25 // Path to the offline archive. 29 // Path to the offline archive.
26 optional string file_path = 4; 30 optional string file_path = 4;
27 31
28 // Size of the offline archive. 32 // Size of the offline archive.
29 optional int64 file_size = 5; 33 optional int64 file_size = 5;
30 34
(...skipping 10 matching lines...) Expand all
41 enum Flags { 45 enum Flags {
42 // No flag is set. 46 // No flag is set.
43 NONE = 0; 47 NONE = 0;
44 // Indicates that the page is marked for deletion. The real deletion will 48 // Indicates that the page is marked for deletion. The real deletion will
45 // occur soon, after which the undo will not be possible. 49 // occur soon, after which the undo will not be possible.
46 MARKED_FOR_DELETION = 1; 50 MARKED_FOR_DELETION = 1;
47 }; 51 };
48 52
49 // Flags for the offline page. 53 // Flags for the offline page.
50 optional Flags flags = 9; 54 optional Flags flags = 9;
55
56 // Information about this offline page in the namespace/id of the client that
57 // requested that it be saved. Useful for reverse lookups.
58
59 // Namespace (e.g. client name) to separate the (possibly identical) ids
60 // from two different clients.
61 optional string client_id_name_space = 11;
62 // Identifier that has meaning for clients of the offline page API.
63 // This is provided by consumers of the offline pages API and is opaque to us.
64 optional string client_id = 12;
51 } 65 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698