Refactor the offline page storage to include client namespace and id.

chrome/browser/android/offline_pages/offline_page_bridge.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
 
 #include <stdint.h>
 
 #include "base/android/jni_android.h"
@@ skipping 15 matching lines @@
 class OfflinePageBridge : public OfflinePageModel::Observer {
  public:
   OfflinePageBridge(JNIEnv* env,
                     jobject obj,
                     content::BrowserContext* browser_context);
   void Destroy(JNIEnv*, const base::android::JavaParamRef<jobject>&);
 
   // OfflinePageModel::Observer implementation.
   void OfflinePageModelLoaded(OfflinePageModel* model) override;
   void OfflinePageModelChanged(OfflinePageModel* model) override;
-  void OfflinePageDeleted(int64_t bookmark_id) override;
+  void OfflinePageDeleted(int64_t offline_id) override;
 
   void GetAllPages(JNIEnv* env,
                    const base::android::JavaParamRef<jobject>& obj,
                    const base::android::JavaParamRef<jobject>& j_result_obj);
   void GetPagesToCleanUp(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jobject>& j_result_obj);
 
-  base::android::ScopedJavaLocalRef<jobject> GetPageByBookmarkId(
+  base::android::ScopedJavaLocalRef<jlongArray> GetOfflineIdsForClientId(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
-      jlong bookmark_id);
+      const base::android::JavaParamRef<jstring>& client_id_namespace,

[fgorski, 2016/02/26 19:29:22]

nit: j_client_id_namespace

[bburns, 2016/02/27 00:48:19]

Done.

+      const base::android::JavaParamRef<jstring>& client_id);

[fgorski, 2016/02/26 19:29:22]

nit: ditto

[bburns, 2016/02/27 00:48:19]

Done.

+
+  base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj,
+      jlong offline_id);
 
   base::android::ScopedJavaLocalRef<jobject> GetPageByOnlineURL(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jstring>& online_url);
 
   void SavePage(JNIEnv* env,
                 const base::android::JavaParamRef<jobject>& obj,
                 const base::android::JavaParamRef<jobject>& j_callback_obj,
                 const base::android::JavaParamRef<jobject>& j_web_contents,
-                jlong bookmark_id);
+                const base::android::JavaParamRef<jstring>& client_id_namespace,

[fgorski, 2016/02/26 19:29:22]

nit: ditto

[bburns, 2016/02/27 00:48:19]

Done.

+                const base::android::JavaParamRef<jstring>& client_id);

[fgorski, 2016/02/26 19:29:22]

nit: ditto

[bburns, 2016/02/27 00:48:19]

Done.

 
   void MarkPageAccessed(JNIEnv* env,
                         const base::android::JavaParamRef<jobject>& obj,
-                        jlong bookmark_id);
+                        jlong offline_id);
 
   void DeletePage(JNIEnv* env,
                   const base::android::JavaParamRef<jobject>& obj,
                   const base::android::JavaParamRef<jobject>& j_callback_obj,
-                  jlong bookmark_id);
+                  jlong offline_id);
 
   void DeletePages(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jobject>& j_callback_obj,
-      const base::android::JavaParamRef<jlongArray>& bookmark_ids_array);
+      const base::android::JavaParamRef<jlongArray>& offline_ids_array);

[fgorski, 2016/02/26 19:29:22]

nit: ditto.


Notice I skipped the jlongs, as they are usable in the C++ code.

[bburns, 2016/02/27 00:48:19]

Done.

 
   void CheckMetadataConsistency(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
 
   base::android::ScopedJavaLocalRef<jstring> GetOfflineUrlForOnlineUrl(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jstring>& j_online_url);
 
@@ skipping 13 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge);
 };
 
 bool RegisterOfflinePageBridge(JNIEnv* env);
 
 }  // namespace android
 }  // namespace offline_pages
 
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_