Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.bookmarks; 5 package org.chromium.chrome.browser.bookmarks;
6 6
7 import org.chromium.base.ObserverList; 7 import org.chromium.base.ObserverList;
8 import org.chromium.base.VisibleForTesting; 8 import org.chromium.base.VisibleForTesting;
9 import org.chromium.base.metrics.RecordHistogram; 9 import org.chromium.base.metrics.RecordHistogram;
10 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge; 10 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 * @param webContents A {@link WebContents} object. 228 * @param webContents A {@link WebContents} object.
229 * @param callback The callback to be invoked when the offline copy is saved. 229 * @param callback The callback to be invoked when the offline copy is saved.
230 */ 230 */
231 public void saveOfflinePage(final BookmarkId bookmarkId, WebContents webCont ents, 231 public void saveOfflinePage(final BookmarkId bookmarkId, WebContents webCont ents,
232 final AddBookmarkCallback callback) { 232 final AddBookmarkCallback callback) {
233 if (mOfflinePageBridge != null) { 233 if (mOfflinePageBridge != null) {
234 RecordHistogram.recordBooleanHistogram("OfflinePages.IncognitoSave", 234 RecordHistogram.recordBooleanHistogram("OfflinePages.IncognitoSave",
235 webContents.isIncognito()); 235 webContents.isIncognito());
236 mOfflinePageBridge.savePage(webContents, bookmarkId, new SavePageCal lback() { 236 mOfflinePageBridge.savePage(webContents, bookmarkId, new SavePageCal lback() {
237 @Override 237 @Override
238 public void onSavePageDone(int savePageResult, String url) { 238 public void onSavePageDone(int savePageResult, String url, long offlineId) {
239 int saveResult; 239 int saveResult;
240 if (savePageResult == SavePageResult.SUCCESS) { 240 if (savePageResult == SavePageResult.SUCCESS) {
241 saveResult = AddBookmarkCallback.SAVED; 241 saveResult = AddBookmarkCallback.SAVED;
242 } else if (savePageResult == SavePageResult.SKIPPED) { 242 } else if (savePageResult == SavePageResult.SKIPPED) {
243 saveResult = AddBookmarkCallback.SKIPPED; 243 saveResult = AddBookmarkCallback.SKIPPED;
244 } else { 244 } else {
245 saveResult = AddBookmarkCallback.ERROR; 245 saveResult = AddBookmarkCallback.ERROR;
246 } 246 }
247 callback.onBookmarkAdded(bookmarkId, saveResult); 247 callback.onBookmarkAdded(bookmarkId, saveResult);
248 } 248 }
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 return bookmarkIds; 306 return bookmarkIds;
307 } 307 }
308 308
309 /** 309 /**
310 * @return Offline page bridge. 310 * @return Offline page bridge.
311 */ 311 */
312 public OfflinePageBridge getOfflinePageBridge() { 312 public OfflinePageBridge getOfflinePageBridge() {
313 return mOfflinePageBridge; 313 return mOfflinePageBridge;
314 } 314 }
315 } 315 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698