MIPS: Support r6 max, min floating point instructions.

MIPS: Support r6 min, max floating point instructions.

Use macro instructions for min, max ops to get the same functionality on
pre-r6 and r6 targets.

BUG=
TEST=mjsunit/math-min-max, cctest/test-macro-assembler-mips64/min_max_nan, cctest/test-macro-assembler-mips/min_max_nan, cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips/min_max

Committed: https://crrev.com/d4a391bb7a7d1cec861f168eeeece1633e633946
Cr-Commit-Position: refs/heads/master@{#35073}

[balazs.kilvady, 2016-02-12 16:19:10]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 16:19:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694833002/1

[balazs.kilvady, 2016-02-12 16:24:47]

Description was changed from

==========
MIPS: Support r6 max, min floating point instructions.

Use macro instructions for max, min ops to get the same functionality on
pre-r6 and r6 target HWs.

BUG=
==========

to

==========
MIPS: Support r6 min, max floating point instructions.

Use macro instructions for min, max ops to get the same functionality on
pre-r6 and r6 targets.

BUG=
TEST=mjsunit/math-min-max, cctest/test-macro-assembler-mips64/min_max_nan,
cctest/test-macro-assembler-mips/min_max_nan,
cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips/min_max
==========

[balazs.kilvady, 2016-02-12 16:24:47]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, alan.li@imgtec.com, gergely.kis@imgtec.com,
ivica.bogosavljevic@imgtec.com, marija.antic@imgtec.com

[balazs.kilvady, 2016-02-12 16:27:00]

I run quickcheck tests on r2, r6, 64/32-bit simulators and critical tests on 32
and 64 bits r2 boards. All tests passed. PTAL.

[commit-bot: I haz the power, 2016-02-12 17:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 17:28:46]

Dry run: This issue passed the CQ dry run.

[balazs.kilvady, 2016-02-19 10:38:18]

Ping.

[balazs.kilvady, 2016-02-23 18:45:32]

On 2016/02/19 10:38:18, balazs.kilvady wrote:
> Ping.

Ping.

[Alan Li, 2016-02-25 04:25:28]

lgtm

[akos.palfi.imgtec, 2016-03-17 18:17:48]

LGTM

[balazs.kilvady, 2016-03-25 16:29:55]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 16:30:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694833002/20001

[commit-bot: I haz the power, 2016-03-25 16:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 16:45:20]

Dry run: This issue passed the CQ dry run.

[balazs.kilvady, 2016-03-25 16:47:02]

The CQ bit was checked by balazs.kilvady@imgtec.com

[balazs.kilvady, 2016-03-25 16:47:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
akos.palfi@imgtec.com, alan.li@imgtec.com
Link to the patchset: https://codereview.chromium.org/1694833002/#ps20001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-03-25 16:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694833002/20001

[commit-bot: I haz the power, 2016-03-25 16:51:18]

Description was changed from

==========
MIPS: Support r6 min, max floating point instructions.

Use macro instructions for min, max ops to get the same functionality on
pre-r6 and r6 targets.

BUG=
TEST=mjsunit/math-min-max, cctest/test-macro-assembler-mips64/min_max_nan,
cctest/test-macro-assembler-mips/min_max_nan,
cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips/min_max
==========

to

==========
MIPS: Support r6 min, max floating point instructions.

Use macro instructions for min, max ops to get the same functionality on
pre-r6 and r6 targets.

BUG=
TEST=mjsunit/math-min-max, cctest/test-macro-assembler-mips64/min_max_nan,
cctest/test-macro-assembler-mips/min_max_nan,
cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips/min_max
==========

[commit-bot: I haz the power, 2016-03-25 16:51:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 16:51:28]

Description was changed from

==========
MIPS: Support r6 min, max floating point instructions.

Use macro instructions for min, max ops to get the same functionality on
pre-r6 and r6 targets.

BUG=
TEST=mjsunit/math-min-max, cctest/test-macro-assembler-mips64/min_max_nan,
cctest/test-macro-assembler-mips/min_max_nan,
cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips/min_max
==========

to

==========
MIPS: Support r6 min, max floating point instructions.

Use macro instructions for min, max ops to get the same functionality on
pre-r6 and r6 targets.

BUG=
TEST=mjsunit/math-min-max, cctest/test-macro-assembler-mips64/min_max_nan,
cctest/test-macro-assembler-mips/min_max_nan,
cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips/min_max

Committed: https://crrev.com/d4a391bb7a7d1cec861f168eeeece1633e633946
Cr-Commit-Position: refs/heads/master@{#35073}
==========

[commit-bot: I haz the power, 2016-03-25 16:51:30]

Patchset 2 (id:??) landed as
https://crrev.com/d4a391bb7a7d1cec861f168eeeece1633e633946
Cr-Commit-Position: refs/heads/master@{#35073}

[Michael Lippautz, 2016-03-29 15:20:58]

mlippautz@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Michael Lippautz, 2016-03-29 15:20:58]

Can somebody have a look, please? If you need a proper repro I can send you one
-- just drop me a line.

https://codereview.chromium.org/1694833002/diff/20001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (left):

https://codereview.chromium.org/1694833002/diff/20001/src/mips/builtins-mips....
src/mips/builtins-mips.cc:185: __ SmiTag(a0);
This is not GC save. There exists a path (at least on the simulator) to trigger
a GC from ToNumberStub which expects values on the stack to be properly tagged. 

The rather large trace:
    #0 0x95ff28d in v8::internal::MemoryChunk::InNewSpace()
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/spaces.h:705:13
    #1 0x95ff28d in v8::internal::NewSpace::Contains(v8::internal::HeapObject*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/spaces-inl.h:224
    #2 0x95ff28d in v8::internal::NewSpace::Contains(v8::internal::Object*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/spaces-inl.h:228
    #3 0x95ff28d in v8::internal::Heap::InNewSpace(v8::internal::Object*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap-inl.h:359
    #4 0x95ff28d in
v8::internal::ScavengeVisitor::ScavengePointer(v8::internal::Object**)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/scavenger.cc:464
    #5 0x95ff28d in
v8::internal::ScavengeVisitor::VisitPointers(v8::internal::Object**,
v8::internal::Object**)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/scavenger.cc:458
    #6 0x936328c in
v8::internal::StandardFrame::IterateExpressions(v8::internal::ObjectVisitor*)
const
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/frames.cc:1497:3
    #7 0x936328c in
v8::internal::InternalFrame::Iterate(v8::internal::ObjectVisitor*) const
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/frames.cc:1509
    #8 0x97fe854 in v8::internal::Isolate::Iterate(v8::internal::ObjectVisitor*,
v8::internal::ThreadLocalTop*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/isolate.cc:219:5
    #9 0x97fec7c in v8::internal::Isolate::Iterate(v8::internal::ObjectVisitor*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/isolate.cc:226:3
    #10 0x94aaf0c in
v8::internal::Heap::IterateStrongRoots(v8::internal::ObjectVisitor*,
v8::internal::VisitMode)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap.cc:4814:3
    #11 0x9420d26 in
v8::internal::Heap::IterateRoots(v8::internal::ObjectVisitor*,
v8::internal::VisitMode)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap.cc:4780:3
    #12 0x9420d26 in v8::internal::Heap::Scavenge()
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap.cc:1693
    #13 0x9415b06 in
v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector,
v8::GCCallbackFlags)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap.cc:1329:7
    #14 0x94107a1 in
v8::internal::Heap::CollectGarbage(v8::internal::GarbageCollector, char const*,
char const*, v8::GCCallbackFlags)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap.cc:1021:11
    #15 0x9228949 in
v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, char const*,
v8::GCCallbackFlags)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/heap/heap-inl.h:542:10
    #16 0x9228949 in v8::internal::Factory::NewFixedArray(int,
v8::internal::PretenureFlag)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/factory.cc:127
    #17 0xa554a60 in v8::internal::FeedbackNexus::EnsureArrayOfSize(int)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/type-feedback-vector.cc:292:32
    #18 0xa563cb5 in
v8::internal::LoadICNexus::ConfigurePolymorphic(v8::internal::List<v8::internal::Handle<v8::internal::Map>,
v8::internal::FreeStoreAllocationPolicy>*,
v8::internal::List<v8::internal::Handle<v8::internal::Code>,
v8::internal::FreeStoreAllocationPolicy>*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/type-feedback-vector.cc:565:30
    #19 0x96b4a06 in
v8::internal::IC::ConfigureVectorState(v8::internal::Handle<v8::internal::Name>,
v8::internal::List<v8::internal::Handle<v8::internal::Map>,
v8::internal::FreeStoreAllocationPolicy>*,
v8::internal::List<v8::internal::Handle<v8::internal::Code>,
v8::internal::FreeStoreAllocationPolicy>*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:620:5
    #20 0x96c0250 in
v8::internal::IC::UpdatePolymorphicIC(v8::internal::Handle<v8::internal::Name>,
v8::internal::Handle<v8::internal::Code>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:800:5
    #21 0x96baaa5 in
v8::internal::IC::PatchCache(v8::internal::Handle<v8::internal::Name>,
v8::internal::Handle<v8::internal::Code>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:850:13
    #22 0x96bd7f2 in
v8::internal::LoadIC::UpdateCaches(v8::internal::LookupIterator*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:1054:3
    #23 0x96b693e in
v8::internal::LoadIC::Load(v8::internal::Handle<v8::internal::Object>,
v8::internal::Handle<v8::internal::Name>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:711:17
    #24 0x97090b9 in
v8::internal::__RT_impl_Runtime_LoadIC_Miss(v8::internal::Arguments,
v8::internal::Isolate*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:2255:5
    #25 0x970782b in v8::internal::Runtime_LoadIC_Miss(int,
v8::internal::Object**, v8::internal::Isolate*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/ic/ic.cc:2236:1
    #26 0xa7ba29a in
v8::internal::Simulator::SoftwareInterrupt(v8::internal::Instruction*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:2227:24
    #27 0xa7d5749 in v8::internal::Simulator::DecodeTypeRegisterSPECIAL()
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:3761:5
    #28 0xa7f2329 in
v8::internal::Simulator::DecodeTypeRegister(v8::internal::Instruction*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:3894:7
    #29 0xa7b0d8f in
v8::internal::Simulator::InstructionDecode(v8::internal::Instruction*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4404:7
    #30 0xa7fb311 in v8::internal::Simulator::Execute()
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4437:7
    #31 0xa7fb879 in v8::internal::Simulator::CallInternal(unsigned char*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4499:3
    #32 0xa7fd8c1 in v8::internal::Simulator::Call(unsigned char*, int, ...)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4556:3
    #33 0x920423d in v8::internal::(anonymous
namespace)::Invoke(v8::internal::Isolate*, bool,
v8::internal::Handle<v8::internal::Object>,
v8::internal::Handle<v8::internal::Object>, int,
v8::internal::Handle<v8::internal::Object>*,
v8::internal::Handle<v8::internal::Object>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/execution.cc:97:13
    #34 0x91ffe41 in v8::internal::Execution::Call(v8::internal::Isolate*,
v8::internal::Handle<v8::internal::Object>,
v8::internal::Handle<v8::internal::Object>, int,
v8::internal::Handle<v8::internal::Object>*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/execution.cc:163:10
    #35 0x9be7d23 in
v8::internal::JSReceiver::OrdinaryToPrimitive(v8::internal::Handle<v8::internal::JSReceiver>,
v8::internal::OrdinaryToPrimitiveHint)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/objects.cc:8152:7
    #36 0x99de668 in
v8::internal::JSReceiver::ToPrimitive(v8::internal::Handle<v8::internal::JSReceiver>,
v8::internal::ToPrimitiveHint)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/objects.cc:8125:10
    #37 0x99d9b9f in
v8::internal::Object::ToNumber(v8::internal::Handle<v8::internal::Object>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/objects.cc:140:5
    #38 0xa3e4916 in
v8::internal::__RT_impl_Runtime_ToNumber(v8::internal::Arguments,
v8::internal::Isolate*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/runtime/runtime-object.cc:939:3
    #39 0xa3e3b3b in v8::internal::Runtime_ToNumber(int, v8::internal::Object**,
v8::internal::Isolate*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/runtime/runtime-object.cc:934:1
    #40 0xa7ba29a in
v8::internal::Simulator::SoftwareInterrupt(v8::internal::Instruction*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:2227:24
    #41 0xa7d5749 in v8::internal::Simulator::DecodeTypeRegisterSPECIAL()
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:3761:5
    #42 0xa7f2329 in
v8::internal::Simulator::DecodeTypeRegister(v8::internal::Instruction*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:3894:7
    #43 0xa7b0d8f in
v8::internal::Simulator::InstructionDecode(v8::internal::Instruction*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4404:7
    #44 0xa7fb311 in v8::internal::Simulator::Execute()
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4437:7
    #45 0xa7fb879 in v8::internal::Simulator::CallInternal(unsigned char*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4499:3
    #46 0xa7fd8c1 in v8::internal::Simulator::Call(unsigned char*, int, ...)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/mips/simulator-mips.cc:4556:3
    #47 0x920423d in v8::internal::(anonymous
namespace)::Invoke(v8::internal::Isolate*, bool,
v8::internal::Handle<v8::internal::Object>,
v8::internal::Handle<v8::internal::Object>, int,
v8::internal::Handle<v8::internal::Object>*,
v8::internal::Handle<v8::internal::Object>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/execution.cc:97:13
    #48 0x91ffe41 in v8::internal::Execution::Call(v8::internal::Isolate*,
v8::internal::Handle<v8::internal::Object>,
v8::internal::Handle<v8::internal::Object>, int,
v8::internal::Handle<v8::internal::Object>*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/execution.cc:163:10
    #49 0x821bdef in v8::Script::Run(v8::Local<v8::Context>)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/api.cc:1788:23
    #50 0x81395b6 in v8::Shell::ExecuteString(v8::Isolate*,
v8::Local<v8::String>, v8::Local<v8::Value>, bool, bool, v8::Shell::SourceType)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/d8.cc:390:20
    #51 0x8163e0b in v8::SourceGroup::Execute(v8::Isolate*)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/d8.cc:1531:10
    #52 0x816f5ac in v8::Shell::RunMain(v8::Isolate*, int, char**, bool)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/d8.cc:2033:7
    #53 0x8171883 in v8::Shell::Main(int, char**)
/mnt/data/b/build/slave/V8_Linux_ASAN_mipsel_-_debug_builder/build/v8/src/d8.cc:2499:16

[balazs.kilvady, 2016-03-29 16:22:42]

Thank you for the info. I am going to check and add tag()/untag().