Reland of: Revise the code for premultiplyAlpha=false for createImageBitmap(HTMLCanvasElement)

Reland of: Revise the code for premultiplyAlpha=false for createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

PS#1 causes compilation error, PS#4 should work.

Committed: https://crrev.com/82089a29904df32dcbc0508e332c69c911193e09
Cr-Commit-Position: refs/heads/master@{#375212}

[xidachen, 2016-02-12 13:35:49]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-02-12 13:35:50]

PTAL

[Justin Novosad, 2016-02-12 14:32:01]

Issue title should say ImageBitmap

[Justin Novosad, 2016-02-12 14:32:23]

On 2016/02/12 14:32:01, Justin Novosad wrote:
> Issue title should say ImageBitmap
(somewhere)

[Justin Novosad, 2016-02-12 14:33:51]

On 2016/02/12 14:32:23, Justin Novosad wrote:
> On 2016/02/12 14:32:01, Justin Novosad wrote:
> > Issue title should say ImageBitmap
> (somewhere)

lgtm

[xidachen, 2016-02-12 14:38:55]

Description was changed from

==========
Revise the code for premultiplyAlpha=false for HTMLCanvasElement

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.
==========

to

==========
Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.
==========

[xidachen, 2016-02-12 14:39:37]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 14:39:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694793002/1

[commit-bot: I haz the power, 2016-02-12 15:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 15:35:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xidachen, 2016-02-12 16:01:06]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-02-12 16:03:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694793002/1

[commit-bot: I haz the power, 2016-02-12 16:08:50]

Description was changed from

==========
Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.
==========

to

==========
Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.
==========

[commit-bot: I haz the power, 2016-02-12 16:08:50]

Committed patchset #1 (id:1)

[xidachen, 2016-02-12 16:33:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1693863002/ by xidachen@chromium.org.

The reason for reverting is: Cause compilation error
https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/37356....

[xidachen, 2016-02-12 16:55:43]

Description was changed from

==========
Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.
==========

to

==========
Reland of: Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

PS#1 causes compilation error, PS#4 should work.
==========

[xidachen, 2016-02-12 16:56:23]

xidachen@chromium.org changed reviewers:
+ jbroman@chromium.org

[xidachen, 2016-02-12 16:56:23]

PTAL

[jbroman, 2016-02-12 17:03:08]

Looks like a straightforward rebase and bugfix, lgtm to reland (on the basis of
junov's approval of the original CL).

[xidachen, 2016-02-12 17:04:08]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 17:04:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694793002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694793002/50001

[xidachen, 2016-02-12 18:20:03]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-02-12 18:20:19]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-02-12 18:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1694793002/#ps50001
(title: "update layout test")

[commit-bot: I haz the power, 2016-02-12 18:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 18:22:11]

Dry run: This issue passed the CQ dry run.

[xidachen, 2016-02-12 18:23:29]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-02-12 18:25:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694793002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694793002/50001

[commit-bot: I haz the power, 2016-02-12 18:36:22]

Description was changed from

==========
Reland of: Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

PS#1 causes compilation error, PS#4 should work.
==========

to

==========
Reland of: Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

PS#1 causes compilation error, PS#4 should work.
==========

[commit-bot: I haz the power, 2016-02-12 18:36:23]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-02-16 22:43:26]

Description was changed from

==========
Reland of: Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

PS#1 causes compilation error, PS#4 should work.
==========

to

==========
Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

Committed: https://crrev.com/32f7197769a8ab4b365138856d0be6dfefa3dd6e
Cr-Commit-Position: refs/heads/master@{#375191}
==========

[commit-bot: I haz the power, 2016-02-16 22:43:27]

Patchset 4 (id:??) landed as
https://crrev.com/32f7197769a8ab4b365138856d0be6dfefa3dd6e
Cr-Commit-Position: refs/heads/master@{#375191}

[commit-bot: I haz the power, 2016-02-16 22:43:59]

Description was changed from

==========
Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

Committed: https://crrev.com/32f7197769a8ab4b365138856d0be6dfefa3dd6e
Cr-Commit-Position: refs/heads/master@{#375191}
==========

to

==========
Reland of: Revise the code for premultiplyAlpha=false for
createImageBitmap(HTMLCanvasElement)

It turns out that HTMLCanvasElement is always premultiplied in Blink, so
we cannot simply use a decoder to re-decode it to a un-premultiplied format.
The strategy this CL takes is that after cropping the HTMLCanvasElement
into a SkImage, we convert the SkImage into a un-premultiplied format if
that's what the option specifies.

PS#1 causes compilation error, PS#4 should work.

Committed: https://crrev.com/82089a29904df32dcbc0508e332c69c911193e09
Cr-Commit-Position: refs/heads/master@{#375212}
==========

[commit-bot: I haz the power, 2016-02-16 22:43:59]

Patchset 4 (id:??) landed as
https://crrev.com/82089a29904df32dcbc0508e332c69c911193e09
Cr-Commit-Position: refs/heads/master@{#375212}