Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1694763003: Test and fix resynthesis of nested generic functions. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove workarounds now that #25769 is fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -46 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 16 chunks +79 lines, -46 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 1 chunk +56 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-12 19:28:35 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-12 19:39:37 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-12 19:45:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
27fa44fe6b23703fe5c030f797601b4d7bac81e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698