Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1694743003: [turbofan] Ship turbofan try-catch. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship turbofan try-catch. Committed: https://crrev.com/5bb459ba4daa34e5ed2fca0dd146aa18f9b6b036 Cr-Commit-Position: refs/heads/master@{#33938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Jarin
Shall we?
4 years, 10 months ago (2016-02-12 10:34:36 UTC) #2
Benedikt Meurer
LGTM!!
4 years, 10 months ago (2016-02-12 10:35:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694743003/1
4 years, 10 months ago (2016-02-12 10:36:10 UTC) #6
Michael Starzinger
The strongest of LGTMs!
4 years, 10 months ago (2016-02-12 10:47:07 UTC) #7
Michael Starzinger
The strongest of LGTM!
4 years, 10 months ago (2016-02-12 10:47:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 11:22:18 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5bb459ba4daa34e5ed2fca0dd146aa18f9b6b036 Cr-Commit-Position: refs/heads/master@{#33938}
4 years, 10 months ago (2016-02-12 11:22:59 UTC) #11
Michael Achenbach
Please land expectation rebase request chromium upstream for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/4576 Auto-revert countdown (59, 58, 57, ...)
4 years, 10 months ago (2016-02-12 14:02:49 UTC) #12
Michael Achenbach
4 years, 10 months ago (2016-02-12 14:06:08 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1688403003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Might break layout tests unintended..

Powered by Google App Engine
This is Rietveld 408576698