Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1694703002: Convert mojo_test_apk android_apk->instrumentation_test_apk (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert mojo_test_apk android_apk->instrumentation_test_apk Since it *is* an instrumentation test. BUG=none Committed: https://crrev.com/d02cda7eb11767e96285ebf068bf41384b1d82e9 Cr-Commit-Position: refs/heads/master@{#375229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/config/android/rules.gni View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 8 (3 generated)
agrieve
⛳
4 years, 10 months ago (2016-02-12 15:15:28 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-12 16:32:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694703002/1
4 years, 10 months ago (2016-02-12 18:28:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 19:50:29 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:44:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d02cda7eb11767e96285ebf068bf41384b1d82e9
Cr-Commit-Position: refs/heads/master@{#375229}

Powered by Google App Engine
This is Rietveld 408576698