chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java - Issue 1694673002: Replace update menu badge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Issue 1694673002: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from second self-review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

index 6a11c6db01138991a2eefbd2664e43ec8f044e0c..6362de541a2ba27f466136e7af359e60acd6fcc8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

@@ -569,7 +569,16 @@ public class CustomTabToolbar extends ToolbarLayout implements LocationBar,

}

@Override

- public void removeAppMenuUpdateBadge() {

+ public boolean isShowingAppMenuUpdateBadge() {

+ return false;

+ }

+ @Override

+ public void removeAppMenuUpdateBadge(boolean animate) {

+ }

+ @Override

+ protected void setAppMenuUpdateBadgeToVisible(boolean animate) {

}

@Override