Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java

Issue 1694673002: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
index 15b21bdc06facba39d7d4a68571e3635f2dd6d7c..9f985a85faa7600b5f8c6c7cf367f593deec43b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
@@ -52,12 +52,20 @@ public interface Toolbar {
void showAppMenuUpdateBadge();
/**
+ * Whether the update badge that is displayed on top of the app menu button is showing.
+ */
+ boolean isShowingAppMenuUpdateBadge();
+
+ /**
* Remove the update badge on the app menu button. Initially the badge is invisible so that it
* gets measured and the tab switcher animation looks correct when the badge is first shown. If
- * the badge will never be shown, this method should be called to change the visibility to
- * gone to avoid unnecessary layout work.
+ * the badge will never be shown or should no longer be shown, this method should be called to
+ * change the visibility to gone to avoid unnecessary layout work. The disappearance of the
+ * badge is optionally animated if it was previously visible.
+ *
+ * @param animate Whether the removal of the badge should be animated.
*/
- void removeAppMenuUpdateBadge();
+ void removeAppMenuUpdateBadge(boolean animate);
/**
* Herb: Sets the listener that is told when the "return to previous app" button is clicked.

Powered by Google App Engine
This is Rietveld 408576698