chrome/android/java/res/layout-sw600dp/toolbar.xml - Issue 1694673002: Replace update menu badge

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout-sw600dp/toolbar.xml

Issue 1694673002: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from second self-review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/badge_update_light.png ('k') | chrome/android/java/res/layout/location_bar.xml » ('j') | chrome/android/java/res/layout/toolbar.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <!-- The toolbar containing the URL bar, back button, and NTP button.	6 <!-- The toolbar containing the URL bar, back button, and NTP button.

7 -->	7 -->

8	8

9 <org.chromium.chrome.browser.toolbar.ToolbarTablet	9 <org.chromium.chrome.browser.toolbar.ToolbarTablet

10 xmlns:android="http://schemas.android.com/apk/res/android"	10 xmlns:android="http://schemas.android.com/apk/res/android"

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 android:id="@+id/menu_button"	71 android:id="@+id/menu_button"

72 style="@style/ToolbarButton"	72 style="@style/ToolbarButton"

73 android:src="@drawable/btn_menu"	73 android:src="@drawable/btn_menu"

74 android:contentDescription="@string/accessibility_toolbar_btn_me nu"	74 android:contentDescription="@string/accessibility_toolbar_btn_me nu"

75 android:layout_width="43dp"	75 android:layout_width="43dp"

76 android:paddingEnd="3.5dp" />	76 android:paddingEnd="3.5dp" />

77	77

78 <ImageView	78 <ImageView

79 android:id="@+id/menu_badge"	79 android:id="@+id/menu_badge"

80 style="@style/UpdateMenuBadge"	80 style="@style/UpdateMenuBadge"

81 android:src="@drawable/badge_update"	81 android:src="@drawable/badge_update_dark"

82 android:layout_marginEnd="8.5dp"	82 android:layout_width="43dp"

	83 android:paddingEnd="3.5dp"

83 android:contentDescription="@null" />	84 android:contentDescription="@null" />

84	85

85 </FrameLayout>	86 </FrameLayout>

86 </LinearLayout>	87 </LinearLayout>

87 </org.chromium.chrome.browser.toolbar.ToolbarTablet>	88 </org.chromium.chrome.browser.toolbar.ToolbarTablet>

OLD	NEW