Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1694673002: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 <item name="android:windowEnterAnimation">@anim/snackbar_in</item> 428 <item name="android:windowEnterAnimation">@anim/snackbar_in</item>
429 <item name="android:windowExitAnimation">@anim/snackbar_out</item> 429 <item name="android:windowExitAnimation">@anim/snackbar_out</item>
430 </style> 430 </style>
431 <style name="SnackbarAnimationWithKeyboard"> 431 <style name="SnackbarAnimationWithKeyboard">
432 <item name="android:windowEnterAnimation">@anim/snackbar_in_with_keyboar d</item> 432 <item name="android:windowEnterAnimation">@anim/snackbar_in_with_keyboar d</item>
433 <item name="android:windowExitAnimation">@anim/snackbar_out</item> 433 <item name="android:windowExitAnimation">@anim/snackbar_out</item>
434 </style> 434 </style>
435 <style name="LocationBarButton"> 435 <style name="LocationBarButton">
436 <item name="android:background">@null</item> 436 <item name="android:background">@null</item>
437 </style> 437 </style>
438 <style name="LocationBarMenuButton" parent="LocationBarButton">
439 <item name="android:layout_height">match_parent</item>
440 <item name="android:layout_width">match_parent</item>
441 </style>
438 <style name="ToolbarButton"> 442 <style name="ToolbarButton">
439 <item name="android:background">?attr/selectableItemBackground</item> 443 <item name="android:background">?attr/selectableItemBackground</item>
440 <item name="android:layout_width">48dp</item> 444 <item name="android:layout_width">48dp</item>
441 <item name="android:layout_height">56dp</item> 445 <item name="android:layout_height">56dp</item>
442 <item name="android:scaleType">center</item> 446 <item name="android:scaleType">center</item>
443 </style> 447 </style>
448 <style name="ToolbarMenuButtonPhone" parent="ToolbarButton">
449 <item name="android:layout_gravity">top</item>
450 <item name="android:layout_width">42dp</item>
451 <item name="android:paddingEnd">4dp</item>
452 <item name="android:background">@null</item>
453 </style>
454 <style name="ToolbarMenuButtonTablet" parent="ToolbarButton">
455 <item name="android:layout_width">43dp</item>
456 <item name="android:paddingEnd">3.5dp</item>
457 </style>
444 <style name="AppMenuItem"> 458 <style name="AppMenuItem">
445 <item name="android:paddingStart">16dp</item> 459 <item name="android:paddingStart">16dp</item>
446 <item name="android:paddingEnd">16dp</item> 460 <item name="android:paddingEnd">16dp</item>
447 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> 461 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>
448 </style> 462 </style>
449 <style name="UpdateMenuBadge">
450 <item name="android:layout_height">@dimen/menu_badge_size</item>
451 <item name="android:layout_width">@dimen/menu_badge_size</item>
452 <item name="android:layout_gravity">end|bottom</item>
453 <item name="android:layout_marginBottom">14dp</item>
454 <item name="android:focusable">false</item>
455 <item name="android:importantForAccessibility">no</item>
456 <item name="android:visibility">invisible</item>
457 </style>
458 </resources> 463 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698