src/crankshaft/hydrogen-alias-analysis.h - Issue 1694643004: [crankshaft] TODO bankruptcy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen-alias-analysis.h

Issue 1694643004: [crankshaft] TODO bankruptcy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen-alias-analysis.h

diff --git a/src/crankshaft/hydrogen-alias-analysis.h b/src/crankshaft/hydrogen-alias-analysis.h

index de8d0bdbe5a211dbcf2ed37d852b89abfb51de80..1f32b7ac6e4cfcbab96e45b85e8ea59eb935c087 100644

--- a/src/crankshaft/hydrogen-alias-analysis.h

+++ b/src/crankshaft/hydrogen-alias-analysis.h

@@ -44,7 +44,6 @@ class HAliasAnalyzer : public ZoneObject {

// Constant objects can be distinguished statically.

if (a->IsConstant()) {

- // TODO(titzer): DataEquals() is more efficient, but that's protected.

return a->Equals(b) ? kMustAlias : kNoAlias;

}

return kMayAlias;

« no previous file with comments | « no previous file | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »