Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 169463012: Mojo: Add Dispatcher::{DuplicateBufferHandle,MapBuffer} methods. (Closed)

Created:
6 years, 10 months ago by viettrungluu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add Dispatcher::{DuplicateBufferHandle,MapBuffer} methods. We'll need them to implement shared memory. (Also add TODOs for a bug that I spotted.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -6 lines) Patch
M mojo/system/core_impl.cc View 5 chunks +47 lines, -6 lines 0 comments Download
M mojo/system/core_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/system/dispatcher.h View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/system/dispatcher.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M mojo/system/dispatcher_unittest.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
6 years, 10 months ago (2014-02-22 00:10:50 UTC) #1
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-22 07:36:40 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 10 months ago (2014-02-22 07:58:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/169463012/1
6 years, 10 months ago (2014-02-22 07:59:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 10:10:28 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268483
6 years, 10 months ago (2014-02-22 10:10:28 UTC) #6
viettrungluu
6 years, 10 months ago (2014-02-22 22:31:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r252827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698