Omnibox: Fixes Allow-To-Be-Default-Match Code for HistoryQuick Provider

Omnibox: Fixes Allow-To-Be-Default-Match Code for HistoryQuick Provider

This was broken for prevent-inline-autocomplete mode.  See bug.

BUG=345366
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252809

[Mark P, 2014-02-22 00:01:05]

Peter,

Please take a look.

thanks,
mark

https://codereview.chromium.org/169463011/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/history_quick_provider_unittest.cc (right):

https://codereview.chromium.org/169463011/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/history_quick_provider_unittest.cc:296: if
(can_inline_top_result)
I revised all the tests here so fill_into_edit is checked regardless of
inlineability.
In the process, I made the test for inline_autocompletion explicit rather than
calculated based off fill_into_edit (because sometimes with trailing slashes it
might not be part of fill_into_edit).
I also removed the check that inline_autocompletion is empty when you can't
inline the top result.  If the match isn't inlineable, it doesn't matter what
the inline_autocompletion is.

[Peter Kasting, 2014-02-22 00:57:47]

LGTM

[Mark P, 2014-02-22 01:00:26]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-02-22 01:01:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/169463011/1

[commit-bot: I haz the power, 2014-02-22 01:37:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/169463011/1

[commit-bot: I haz the power, 2014-02-22 05:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-22 05:04:23]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Mark P, 2014-02-22 17:37:27]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-02-22 17:37:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/169463011/1

[commit-bot: I haz the power, 2014-02-22 18:55:36]

Change committed as 252809