Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 169463008: Fix the "Minimize" button of app windows remaining hovered after restore. (Closed)

Created:
6 years, 10 months ago by calamity
Modified:
6 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the "Minimize" button of app windows remaining hovered after restore. This CL sets the minimize button state to unhovered on layout to fix an issue where the hover would be sticky between window minimize and restore. BUG=338319 TEST=Open the settings app from the app launcher. Minimize it and then restore it from the taskbar. The minimize button should not be hovered. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251743

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M apps/ui/views/app_window_frame_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
calamity
6 years, 10 months ago (2014-02-18 05:52:41 UTC) #1
benwells
lgtm
6 years, 10 months ago (2014-02-18 05:57:35 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 10 months ago (2014-02-18 05:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/169463008/90001
6 years, 10 months ago (2014-02-18 05:59:13 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 08:09:26 UTC) #5
Message was sent while issue was closed.
Change committed as 251743

Powered by Google App Engine
This is Rietveld 408576698