Issue 169463003: Replace TSan interface declarations with a header inclusion.

Issue 169463003: Replace TSan interface declarations with a header inclusion. (Closed)

Created:
6 years, 10 months ago by Alexander Potapenko

Modified:
6 years, 10 months ago

Reviewers:
brettw, scottmg

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Replace TSan interface declarations with a header inclusion. BUG=343838 R=scottmg@chromium.org,brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251742

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -346 lines)			Patch
	M	base/atomicops_internals_tsan.h	View		1 chunk	+2 lines, -171 lines	0 comments	Download
	M	third_party/protobuf/src/google/protobuf/stubs/atomicops_internals_tsan.h	View		1 chunk	+2 lines, -175 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm, seems much better than magic prototypes, assuming this header is always going to be ...

6 years, 10 months ago (2014-02-17 20:46:50 UTC) #2

Alexander Potapenko

The CQ bit was checked by glider@chromium.org

6 years, 10 months ago (2014-02-18 05:33:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/169463003/150001

6 years, 10 months ago (2014-02-18 05:33:53 UTC) #5

scottmg

On 2014/02/18 08:02:45, I haz the power (commit-bot) wrote: > Change committed as 251742 The ...

6 years, 10 months ago (2014-02-18 17:30:55 UTC) #7

Alexander Potapenko

6 years, 10 months ago (2014-02-19 11:48:11 UTC) #8

Message was sent while issue was closed.

On 2014/02/18 17:30:55, scottmg wrote:
> On 2014/02/18 08:02:45, I haz the power (commit-bot) wrote:
> > Change committed as 251742
> 
> The protobuf changes need to be upstreamed too though to
> https://code.google.com/p/protobuf/.

Patch in flight: https://code.google.com/p/protobuf/issues/detail?id=607

Expand Messages | Collapse Messages