Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1694613002: Add IceConfig and IceConfigRequest. (Closed)

Created:
4 years, 10 months ago by Sergey Ulanov
Modified:
4 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@url_request
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IceConfig and IceConfigRequest. The new IceConfig struct will be used to pass TURN configuration to PortAllocator. JingleInfoRequest has been moved to remoting/protocol and now implements IceConfigRequest. BUG=577954 Committed: https://crrev.com/58e801a5b7d4a5bfb300280cdf5b8eab6251abae Cr-Commit-Position: refs/heads/master@{#375328}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -272 lines) Patch
A remoting/protocol/ice_config.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A remoting/protocol/ice_config.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/protocol/ice_config_request.h View 1 chunk +31 lines, -0 lines 0 comments Download
A remoting/protocol/jingle_info_request.h View 1 chunk +50 lines, -0 lines 0 comments Download
A + remoting/protocol/jingle_info_request.cc View 1 6 chunks +23 lines, -17 lines 0 comments Download
M remoting/protocol/port_allocator.h View 2 chunks +4 lines, -10 lines 0 comments Download
M remoting/protocol/port_allocator.cc View 1 4 chunks +22 lines, -25 lines 0 comments Download
M remoting/protocol/transport_context.h View 5 chunks +12 lines, -18 lines 0 comments Download
M remoting/protocol/transport_context.cc View 4 chunks +19 lines, -31 lines 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +5 lines, -2 lines 0 comments Download
D remoting/signaling/jingle_info_request.h View 1 chunk +0 lines, -64 lines 0 comments Download
D remoting/signaling/jingle_info_request.cc View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
4 years, 10 months ago (2016-02-12 18:58:06 UTC) #2
Jamie
lgtm https://codereview.chromium.org/1694613002/diff/1/remoting/protocol/ice_config.h File remoting/protocol/ice_config.h (right): https://codereview.chromium.org/1694613002/diff/1/remoting/protocol/ice_config.h#newcode27 remoting/protocol/ice_config.h:27: std::vector<rtc::SocketAddress> stun_hosts; s/hosts/servers/, here and below, for consistency ...
4 years, 10 months ago (2016-02-12 22:48:28 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1694613002/diff/1/remoting/protocol/ice_config.h File remoting/protocol/ice_config.h (right): https://codereview.chromium.org/1694613002/diff/1/remoting/protocol/ice_config.h#newcode27 remoting/protocol/ice_config.h:27: std::vector<rtc::SocketAddress> stun_hosts; On 2016/02/12 22:48:28, Jamie wrote: > s/hosts/servers/, ...
4 years, 10 months ago (2016-02-13 01:11:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694613002/20001
4 years, 10 months ago (2016-02-13 01:14:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-13 02:07:29 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:47:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58e801a5b7d4a5bfb300280cdf5b8eab6251abae
Cr-Commit-Position: refs/heads/master@{#375328}

Powered by Google App Engine
This is Rietveld 408576698