Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 16946005: Fix error handling on errorReportingServer (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
===================================================================
--- tools/testing/dart/browser_controller.dart (revision 23977)
+++ tools/testing/dart/browser_controller.dart (working copy)
@@ -802,9 +802,9 @@
String back = buffer.toString();
request.response.headers.set("Access-Control-Allow-Origin", "*");
- request.response.close().then((_) {}, onError: (error) {
+ request.response.close().catchError((error) {
DebugLogger.error("Error getting error from browser"
- "on uri ${request.uri.path}");
+ "on uri ${request.uri.path}: $error");
});
DebugLogger.error("Error from browser on : "
"${request.uri.path}, data: $back");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698