Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4168)

Unified Diff: chrome/browser/chromeos/cros/network_library_unittest.cc

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removed automation part. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/network_library_unittest.cc
diff --git a/chrome/browser/chromeos/cros/network_library_unittest.cc b/chrome/browser/chromeos/cros/network_library_unittest.cc
index 4608f104d452fae72fd62dfd1f57c357230eb49b..9d5dc6c5ff5322fca089481db7ee77e5d2582f40 100644
--- a/chrome/browser/chromeos/cros/network_library_unittest.cc
+++ b/chrome/browser/chromeos/cros/network_library_unittest.cc
@@ -177,7 +177,8 @@ class NetworkLibraryStubTest : public ::testing::Test {
base::DictionaryValue* expected_configs;
expected_value->GetAsDictionary(&expected_configs);
- cros_->LoadOncNetworks(*onc_network_configs, source);
+ cros_->LoadOncNetworks(*onc_network_configs, source,
+ base::Bind(&onc::test_utils::FakeFingerprintToPEM));
const std::map<std::string, base::DictionaryValue*>& configs =
cros_->GetConfigurations();
@@ -291,14 +292,14 @@ TEST_F(NetworkLibraryStubTest, NetworkConnectWifi) {
TEST_F(NetworkLibraryStubTest, NetworkConnectWifiWithCertPattern) {
scoped_ptr<base::DictionaryValue> onc_root =
- onc::test_utils::ReadTestDictionary("toplevel_wifi_eap_clientcert.onc");
+ onc::test_utils::ReadTestDictionary("certificate-client.onc");
base::ListValue* certificates;
onc_root->GetListWithoutPathExpansion(onc::toplevel_config::kCertificates,
&certificates);
onc::CertificateImporter importer(true /* allow trust imports */);
ASSERT_EQ(onc::CertificateImporter::IMPORT_OK,
- importer.ParseAndStoreCertificates(*certificates, NULL));
+ importer.ParseAndStoreCertificates(*certificates, NULL, NULL));
WifiNetwork* wifi = cros_->FindWifiNetworkByPath("wifi_cert_pattern");
@@ -320,14 +321,14 @@ TEST_F(NetworkLibraryStubTest, NetworkConnectWifiWithCertPattern) {
TEST_F(NetworkLibraryStubTest, NetworkConnectVPNWithCertPattern) {
scoped_ptr<base::DictionaryValue> onc_root =
- onc::test_utils::ReadTestDictionary("toplevel_openvpn_clientcert.onc");
+ onc::test_utils::ReadTestDictionary("certificate-client.onc");
base::ListValue* certificates;
onc_root->GetListWithoutPathExpansion(onc::toplevel_config::kCertificates,
&certificates);
onc::CertificateImporter importer(true /* allow trust imports */);
ASSERT_EQ(onc::CertificateImporter::IMPORT_OK,
- importer.ParseAndStoreCertificates(*certificates, NULL));
+ importer.ParseAndStoreCertificates(*certificates, NULL, NULL));
VirtualNetwork* vpn = cros_->FindVirtualNetworkByPath("vpn_cert_pattern");
@@ -409,7 +410,7 @@ INSTANTIATE_TEST_CASE_P(
ImportParams("managed_toplevel1_normalized.onc",
"chromeos/net/shill_for_managed_toplevel1.json",
onc::ONC_SOURCE_USER_POLICY),
- ImportParams("managed_toplevel2.onc",
+ ImportParams("managed_toplevel2_with_cert_fingerprints.onc",
"chromeos/net/shill_for_managed_toplevel2.json",
onc::ONC_SOURCE_USER_POLICY),
ImportParams("managed_toplevel_l2tpipsec.onc",
@@ -431,10 +432,10 @@ INSTANTIATE_TEST_CASE_P(
"chromeos/net/shill_for_toplevel_wifi_leap.json",
onc::ONC_SOURCE_USER_POLICY),
ImportParams(
- "toplevel_wifi_eap_clientcert.onc",
+ "toplevel_wifi_eap_clientcert_with_cert_fingerprints.onc",
"chromeos/net/shill_for_toplevel_wifi_eap_clientcert.json",
onc::ONC_SOURCE_USER_POLICY),
- ImportParams("toplevel_openvpn_clientcert.onc",
+ ImportParams("toplevel_openvpn_clientcert_with_cert_fingerprints.onc",
"chromeos/net/shill_for_toplevel_openvpn_clientcert.json",
onc::ONC_SOURCE_USER_POLICY),
ImportParams("toplevel_wifi_remove.onc",

Powered by Google App Engine
This is Rietveld 408576698