Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chromeos/network/certificate_handler.cc

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a unit test for the resolve function. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/certificate_handler.h ('k') | chromeos/network/certificate_pattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/certificate_handler.cc
diff --git a/chromeos/network/certificate_handler.cc b/chromeos/network/certificate_handler.cc
index d471813a47c8de16e25578856d7a00e6fba810a2..f1f0e656ee4044133a8e2841a5fb5d828a37e83f 100644
--- a/chromeos/network/certificate_handler.cc
+++ b/chromeos/network/certificate_handler.cc
@@ -19,14 +19,17 @@ CertificateHandler::~CertificateHandler() {
bool CertificateHandler::ImportCertificates(
const base::ListValue& certificates,
onc::ONCSource source,
- net::CertificateList* onc_trusted_certificates) {
+ net::CertificateList* onc_trusted_certificates,
+ CertsByGUID* imported_server_and_ca_certs) {
VLOG(2) << "ONC file has " << certificates.GetSize() << " certificates";
// Web trust is only granted to certificates imported by the user.
bool allow_trust_imports = source == onc::ONC_SOURCE_USER_IMPORT;
onc::CertificateImporter cert_importer(allow_trust_imports);
if (cert_importer.ParseAndStoreCertificates(
- certificates, onc_trusted_certificates) !=
+ certificates,
+ onc_trusted_certificates,
+ imported_server_and_ca_certs) !=
onc::CertificateImporter::IMPORT_OK) {
LOG(ERROR) << "Cannot parse some of the certificates in the ONC from "
<< onc::GetSourceAsString(source);
« no previous file with comments | « chromeos/network/certificate_handler.h ('k') | chromeos/network/certificate_pattern.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698