Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chromeos/dbus/shill_client_helper.cc

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a unit test for the resolve function. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_client_helper.cc
diff --git a/chromeos/dbus/shill_client_helper.cc b/chromeos/dbus/shill_client_helper.cc
index ed9c994c6d604ed5a0a9d7e550b9254713ecd64a..5e6b69b84871340e00bb88896710e189d06a3762 100644
--- a/chromeos/dbus/shill_client_helper.cc
+++ b/chromeos/dbus/shill_client_helper.cc
@@ -384,6 +384,26 @@ void ShillClientHelper::AppendValueDataAsVariant(dbus::MessageWriter* writer,
writer->CloseContainer(&variant_writer);
break;
}
+ case base::Value::TYPE_LIST: {
+ const base::ListValue* list = NULL;
+ value.GetAsList(&list);
+ dbus::MessageWriter variant_writer(NULL);
+ writer->OpenVariant("as", &variant_writer);
+ dbus::MessageWriter array_writer(NULL);
+ variant_writer.OpenArray("s", &array_writer);
+ for (base::ListValue::const_iterator it = list->begin();
+ it != list->end(); ++it) {
+ const base::Value& value = **it;
+ LOG_IF(ERROR, value.GetType() != base::Value::TYPE_STRING)
+ << "Unexpected type " << value.GetType();
+ std::string value_string;
+ value.GetAsString(&value_string);
+ array_writer.AppendString(value_string);
+ }
+ variant_writer.CloseContainer(&array_writer);
+ writer->CloseContainer(&variant_writer);
+ break;
+ }
case base::Value::TYPE_BOOLEAN:
case base::Value::TYPE_INTEGER:
case base::Value::TYPE_DOUBLE:
« no previous file with comments | « chrome/test/data/chromeos/net/shill_for_toplevel_wifi_eap_clientcert.json ('k') | chromeos/network/certificate_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698