Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: chrome/browser/chromeos/cros/cert_library.h

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a unit test for the resolve function. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/cert_library.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/cert_library.h
diff --git a/chrome/browser/chromeos/cros/cert_library.h b/chrome/browser/chromeos/cros/cert_library.h
index 46890cfb839afc676b88c6901a7587f9062a9930..8d595b9abad6868824d63ce28273b1bc5b5b0c4a 100644
--- a/chrome/browser/chromeos/cros/cert_library.h
+++ b/chrome/browser/chromeos/cros/cert_library.h
@@ -68,12 +68,16 @@ class CertLibrary : public CertLoader::Observer {
// Retreives the certificate property for |type| at |index|.
string16 GetCertDisplayStringAt(CertType type, int index) const;
- std::string GetCertNicknameAt(CertType type, int index) const;
+ std::string GetCertPEMAt(CertType type, int index) const;
std::string GetCertPkcs11IdAt(CertType type, int index) const;
bool IsCertHardwareBackedAt(CertType type, int index) const;
- // Returns the index of a Certificate matching |nickname| or -1 if none found.
- int GetCertIndexByNickname(CertType type, const std::string& nickname) const;
+ // Returns the index of a Certificate matching |pem_encoded| or -1 if none
+ // found. This function may be slow depending on the number of stored
+ // certificates.
+ // TOOD(pneubeck): Either make this more efficient, asynchronous or get rid of
+ // it.
+ int GetCertIndexByPEM(CertType type, const std::string& pem_encoded) const;
// Same as above but for a PKCS#11 id. TODO(stevenjb): Replace this with a
// better mechanism for uniquely idientifying certificates, crbug.com/236978.
int GetCertIndexByPkcs11Id(CertType type, const std::string& pkcs11_id) const;
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/cert_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698