Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chromeos/network/onc/onc_utils_unittest.cc

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix trust update. Add a utils test. Remove X509 dependency from Shill parsing. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_utils_unittest.cc
diff --git a/chromeos/network/onc/onc_utils_unittest.cc b/chromeos/network/onc/onc_utils_unittest.cc
index 97a0cb28dc0a578e901b68ab9f7043ab49c01287..fb4203f73a224cbe641ad5d7334d580ad2b4c808 100644
--- a/chromeos/network/onc/onc_utils_unittest.cc
+++ b/chromeos/network/onc/onc_utils_unittest.cc
@@ -9,6 +9,8 @@
#include "base/values.h"
#include "chromeos/network/onc/onc_signature.h"
#include "chromeos/network/onc/onc_test_utils.h"
+#include "net/cert/x509_certificate.h"
+#include "net/test/test_certificate_data.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
@@ -100,5 +102,20 @@ TEST(ONCStringExpansion, WiFi_EAP) {
EXPECT_EQ(actual_expanded, std::string("abc ") + kLoginId + "@my.domain.com");
}
+TEST(ONCCalculateFingerprint, FingerprintMethodsIdentical) {
+ scoped_refptr<net::X509Certificate> cert(
+ net::X509Certificate::CreateFromBytes(
+ reinterpret_cast<const char*>(google_der),
+ sizeof(google_der)));
+
+ std::string fingerprint1 = GetHexFingerprintOfCert(*cert);
+ std::string pem_encoded_cert;
+ EXPECT_TRUE(net::X509Certificate::GetPEMEncoded(cert->os_cert_handle(),
+ &pem_encoded_cert));
+
+ std::string fingerprint2 = GetHexFingerprintOfPEMCert(pem_encoded_cert);
+ EXPECT_EQ(fingerprint1, fingerprint2);
+}
+
} // namespace onc
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698