Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/IceInstARM32.cpp

Issue 1694533002: Add move vector to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests_lit/assembler/arm32/vec-move.ll » ('j') | tests_lit/assembler/arm32/vec-move.ll » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index f01cd53bd612db0a6a3825151aa2c866de80e7d2..90ee6205afda18df82f9cc25b495c69fe5f8346b 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1566,8 +1566,8 @@ void InstARM32Mov::emitIAS(const Cfg *Func) const {
case IceType_v8i16:
case IceType_v4i32:
case IceType_v4f32:
- // TODO(kschimpf): Add vector moves.
- emitUsingTextFixup(Func);
+ assert(SrcTy == DestTy && "Mov on different vector types");
+ Asm->vorrq(Dest, Src0, Src0);
Eric Holk 2016/02/11 19:24:22 The other moves in this function pass the result o
Karl 2016/02/11 22:10:28 The same can be said for the emit() method. Adding
return;
}
llvm::report_fatal_error("Mov: don't know how to move " +
« no previous file with comments | « no previous file | tests_lit/assembler/arm32/vec-move.ll » ('j') | tests_lit/assembler/arm32/vec-move.ll » ('J')

Powered by Google App Engine
This is Rietveld 408576698