Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1694523003: Revert of [interpreter] Make d8's TryCatch block be verbose. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Make d8's TryCatch block be verbose. (patchset #3 id:40001 of https://codereview.chromium.org/1691723002/ ) Reason for revert: [Sheriff] Speculative revert. Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/3944 Somehow https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d63b29 seems to hide it again and then https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b250111dedd lets it show up again. Reproduced locally. Original issue's description: > [interpreter] Make d8's TryCatch block be verbose. > > This changes "d8" to no longer report exceptions as being "caught" when > it comes to the catch prediction mechanism in our debugger. This treats > scripts as being truly top-level when it comes to exception handling and > will allow us to properly test the catch prediction mechanism using just > mjsunit tests alone. > > R=yangguo@chromium.org > BUG=v8:4674 > LOG=n > > Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45 > Cr-Commit-Position: refs/heads/master@{#33898} TBR=yangguo@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Committed: https://crrev.com/f9eef1f33d2e5cde8cb948424e7ebf509090aa59 Cr-Commit-Position: refs/heads/master@{#33921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/d8.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [interpreter] Make d8's TryCatch block be verbose.
4 years, 10 months ago (2016-02-11 23:10:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694523003/1
4 years, 10 months ago (2016-02-11 23:10:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 23:10:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f9eef1f33d2e5cde8cb948424e7ebf509090aa59 Cr-Commit-Position: refs/heads/master@{#33921}
4 years, 10 months ago (2016-02-11 23:11:21 UTC) #6
Michael Starzinger
4 years, 10 months ago (2016-02-12 09:11:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1692133002/ by mstarzinger@chromium.org.

The reason for reverting is: No fix needed, original CL was perfectly fine!.

Powered by Google App Engine
This is Rietveld 408576698