components/autofill/core/browser/personal_data_manager.cc - Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/credit_card_field.cc ('K') | « components/autofill/core/browser/payments/payments_client.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.cc

diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc

index 315cec1b6f3b069a6edfb3bee89950107ac7c5a4..f174f018e31b632f7c1d45436be7620dd3d8c43f 100644

--- a/components/autofill/core/browser/personal_data_manager.cc

+++ b/components/autofill/core/browser/personal_data_manager.cc

@@ -820,9 +820,9 @@ std::vector<Suggestion> PersonalDataManager::GetCreditCardSuggestions(

suggestion->label = credit_card->GetInfo(

AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);

} else if (credit_card->number().empty()) {

- if (type.GetStorableType() != CREDIT_CARD_NAME) {

- suggestion->label =

- credit_card->GetInfo(AutofillType(CREDIT_CARD_NAME), app_locale_);

+ if (type.GetStorableType() != CREDIT_CARD_NAME_FULL) {

+ suggestion->label = credit_card->GetInfo(

+ AutofillType(CREDIT_CARD_NAME_FULL), app_locale_);

}

} else {

#if defined(OS_ANDROID)