Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: components/autofill/core/browser/field_types.h

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch2 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/field_types.h
diff --git a/components/autofill/core/browser/field_types.h b/components/autofill/core/browser/field_types.h
index a3787e076ec2d8d8a6e97b1ac360494775a7164a..92f3a70a444d932733184a2c1f2b1e7a8b6a8754 100644
--- a/components/autofill/core/browser/field_types.h
+++ b/components/autofill/core/browser/field_types.h
@@ -72,7 +72,7 @@ enum ServerFieldType {
// ADDRESS_SHIPPING values [44,50] are deprecated.
- CREDIT_CARD_NAME = 51,
+ CREDIT_CARD_NAME_FULL = 51,
CREDIT_CARD_NUMBER = 52,
CREDIT_CARD_EXP_MONTH = 53,
CREDIT_CARD_EXP_2_DIGIT_YEAR = 54,
@@ -149,10 +149,14 @@ enum ServerFieldType {
PROBABLY_NEW_PASSWORD = 89,
NOT_NEW_PASSWORD = 90,
+ // Additional field types for credit card fields.
+ CREDIT_CARD_NAME_FIRST = 91,
+ CREDIT_CARD_NAME_LAST = 92,
+
// No new types can be added without a corresponding change to the Autofill
// server.
- MAX_VALID_FIELD_TYPE = 91,
+ MAX_VALID_FIELD_TYPE = 93,
};
// The list of all HTML autocomplete field type hints supported by Chrome.
@@ -184,7 +188,9 @@ enum HtmlFieldType {
HTML_TYPE_FULL_ADDRESS, // The complete address, formatted for display.
// Credit card types.
- HTML_TYPE_CREDIT_CARD_NAME,
+ HTML_TYPE_CREDIT_CARD_NAME_FULL,
+ HTML_TYPE_CREDIT_CARD_NAME_FIRST,
+ HTML_TYPE_CREDIT_CARD_NAME_LAST,
HTML_TYPE_CREDIT_CARD_NUMBER,
HTML_TYPE_CREDIT_CARD_EXP,
HTML_TYPE_CREDIT_CARD_EXP_MONTH,

Powered by Google App Engine
This is Rietveld 408576698