Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/credit_card_field_unittest.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch2 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/core/browser/credit_card_field.cc ('K') | « components/autofill/core/browser/credit_card_field.cc ('k') | components/autofill/core/browser/credit_card_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/credit_card_field_unittest.cc
diff --git a/components/autofill/core/browser/credit_card_field_unittest.cc b/components/autofill/core/browser/credit_card_field_unittest.cc
index 83d23c74c974fce1eff6f494d725188bcd5dc071..474c920c56dd73129de05df9e8dd071a0a37212b 100644
--- a/components/autofill/core/browser/credit_card_field_unittest.cc
+++ b/components/autofill/core/browser/credit_card_field_unittest.cc
@@ -153,7 +153,7 @@ TEST_F(CreditCardFieldTest, ParseFullCreditCard) {
EXPECT_EQ(CREDIT_CARD_TYPE, field_type_map_[ASCIIToUTF16("type")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number")]);
@@ -195,7 +195,7 @@ TEST_F(CreditCardFieldTest, ParseExpMonthYear) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number2")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
@@ -233,7 +233,7 @@ TEST_F(CreditCardFieldTest, ParseExpMonthYear2) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number2")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
@@ -267,7 +267,7 @@ TEST_F(CreditCardFieldTest, ParseExpField) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number2")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
@@ -298,7 +298,7 @@ TEST_F(CreditCardFieldTest, ParseExpField2DigitYear) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number2")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
@@ -330,7 +330,7 @@ TEST_F(CreditCardFieldTest, ParseExpField2DigitYearDueToMaxLength) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number2")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
@@ -361,7 +361,7 @@ TEST_F(CreditCardFieldTest, ParseExpField4DigitYear) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("number2")) != field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
@@ -384,7 +384,7 @@ TEST_F(CreditCardFieldTest, ParseCreditCardHolderNameWithCCFullName) {
EXPECT_TRUE(ClassifyField());
ASSERT_TRUE(
field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
}
// Verifies that <input type="month"> controls are able to be parsed correctly.
@@ -545,7 +545,7 @@ TEST_F(CreditCardFieldTest, ParseMultipleCreditCardNumbers) {
ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("name1")) !=
field_type_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL, field_type_map_[ASCIIToUTF16("name1")]);
ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number2")) !=
field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
« components/autofill/core/browser/credit_card_field.cc ('K') | « components/autofill/core/browser/credit_card_field.cc ('k') | components/autofill/core/browser/credit_card_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698