components/autofill/core/browser/autofill_type.cc - Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_type.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_regex_constants.cc ('K') | « components/autofill/core/browser/autofill_regex_constants.cc ('k') | components/autofill/core/browser/contact_info.cc » ('j') | components/autofill/core/browser/field_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_type.cc

diff --git a/components/autofill/core/browser/autofill_type.cc b/components/autofill/core/browser/autofill_type.cc

index 71d49558bc902404652a1743e157f1ffd61b0782..16a53a12a45eccc91e13b6d513c225390aec6739 100644

--- a/components/autofill/core/browser/autofill_type.cc

+++ b/components/autofill/core/browser/autofill_type.cc

@@ -103,6 +103,8 @@ FieldTypeGroup AutofillType::group() const {

return ADDRESS_BILLING;

case CREDIT_CARD_NAME:

Mathieu 2016/02/23 15:23:03 should probably rename CREDIT_CARD_NAME_FULL.

sebsg 2016/02/24 18:49:44 Done.

+ case CREDIT_CARD_NAME_FIRST:

+ case CREDIT_CARD_NAME_LAST:

case CREDIT_CARD_NUMBER:

case CREDIT_CARD_EXP_MONTH:

case CREDIT_CARD_EXP_2_DIGIT_YEAR:

@@ -572,6 +574,10 @@ std::string AutofillType::ToString() const {

return "ADDRESS_BILLING_COUNTRY";

case CREDIT_CARD_NAME:

return "CREDIT_CARD_NAME";

+ case CREDIT_CARD_NAME_FIRST:

+ return "CREDIT_CARD_NAME_FIRST";

+ case CREDIT_CARD_NAME_LAST:

+ return "CREDIT_CARD_NAME_LAST";

case CREDIT_CARD_NUMBER:

return "CREDIT_CARD_NUMBER";

case CREDIT_CARD_EXP_MONTH: